Re: [PATCH v2] MUSB: fix wrongly created sysfs entry

[Felipe Balbi <me@felipebalbi.com>]

Hi,

On Tue, Dec 16, 2008 at 01:25:58AM +0530, Pandita, Vikram wrote:
> Agreed. In that case, we still need the following patch:
> Otherwise the srp entry does not get deleted on rmmod.

makes sense, can you just update one thing:

> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 5280dba..824ea57 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1829,7 +1829,7 @@ static void musb_free(struct musb *musb)
>  #ifdef CONFIG_SYSFS
>  	device_remove_file(musb->controller, &dev_attr_mode);
>  	device_remove_file(musb->controller, &dev_attr_vbus);
> -#ifdef CONFIG_USB_MUSB_OTG
> +#ifdef CONFIG_USB_GADGET_MUSB_HDRC
>  	device_remove_file(musb->controller, &dev_attr_srp);
>  #endif
>  #endif
> @@ -2060,7 +2060,7 @@ bad_config:
>  	status = device_create_file(dev, &dev_attr_vbus);
>  #ifdef CONFIG_USB_GADGET_MUSB_HDRC
>  	status = device_create_file(dev, &dev_attr_srp);
> -#endif /* CONFIG_USB_GADGET_MUSB_HDRC */
> +#endif

leave the comment there :-)

-- 
balbi