All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Janne Kulmala <janne.t.kulmala@tut.fi>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, "Pallipadi,
	Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: Re: x86: Fix HPET for Fujitsu u9200
Date: Tue, 16 Dec 2008 20:38:43 +0100	[thread overview]
Message-ID: <20081216193843.GD843@elte.hu> (raw)
In-Reply-To: <4947938D.3010004@tut.fi>


* Janne Kulmala <janne.t.kulmala@tut.fi> wrote:

> HPET timer is listed in the ACPI table, but needs a quirk entry in order 
> to work. Unfortunately, the quirk code runs after first HPET 
> hpet_enable() which has already determined that the timer doesn't work 
> (reads 0xFFFFFFFF). This patch allows hpet_enable() to be called again 
> after running the quirk code.
>
> Signed-off-by: Janne Kulmala <janne.t.kulmala@tut.fi>

applied to tip/timers/hpet, thanks Janne!

Venki, is this new hpet force-enable quirk entry generally OK:

 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_1,
                         ich_force_enable_hpet);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_4,
+                        ich_force_enable_hpet);

i guess it's OK since we enable hpet on ICH8_1 already. Should we perhaps 
convert these quirks somehow to some ">= threshold_version" condition, 
instead of having to enumerate everything?

	Ingo

      reply	other threads:[~2008-12-16 19:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16 11:39 x86: Fix HPET for Fujitsu u9200 Janne Kulmala
2008-12-16 19:38 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081216193843.GD843@elte.hu \
    --to=mingo@elte.hu \
    --cc=janne.t.kulmala@tut.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.