From: Willy Tarreau <w@1wt.eu>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] ide: fix setting nIEN on idle devices
Date: Tue, 16 Dec 2008 21:24:36 +0100 [thread overview]
Message-ID: <20081216202436.GA2506@1wt.eu> (raw)
In-Reply-To: <200812161957.52419.bzolnier@gmail.com>
On Tue, Dec 16, 2008 at 07:57:52PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 14 December 2008, Willy Tarreau wrote:
> > Hi Bart,
> >
> > On Sun, Dec 14, 2008 at 12:39:32AM +0100, Bartlomiej Zolnierkiewicz wrote:
> > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > > Subject: [PATCH] ide: fix setting nIEN on idle devices
> > >
> > > Fix do_ide_request() to operate on previous device / port instead of
> > > the current one. The original code was wrong since at least Feb 2002
> > > (2.4.0 timeframe).
> >
> > What could be the impact of this bug ? Should I backport your fix to 2.4 ?
>
> The fix results in better handling of unexpected IRQs on serialized IDE
> ports. However since unexpected IRQs coming from a device is not something
> we should normally see and I don't recall seeing any bugreports that would
> be potentially closed by this fix I don't think that there is an urgent need
> to backport it (thanks for caring about 2.4.x users anyway!).
OK, thanks Bart !
Willy
next prev parent reply other threads:[~2008-12-16 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 23:39 [PATCH 0/6] ide: final bits of struct hwgroup_s -> struct ide_host change Bartlomiej Zolnierkiewicz
2008-12-13 23:39 ` [PATCH 1/6] ide: fix setting nIEN on idle devices Bartlomiej Zolnierkiewicz
2008-12-14 7:06 ` Willy Tarreau
2008-12-16 18:57 ` Bartlomiej Zolnierkiewicz
2008-12-16 20:24 ` Willy Tarreau [this message]
2008-12-13 23:39 ` [PATCH 2/6] ide: add ->cur_port to struct ide_host and use it for serialized hosts Bartlomiej Zolnierkiewicz
2008-12-13 23:39 ` [PATCH 3/6] ide: use per-port IRQ handlers Bartlomiej Zolnierkiewicz
2008-12-13 23:39 ` [PATCH 4/6] ide: remove hwgroup->hwif and {drive,hwif}->next Bartlomiej Zolnierkiewicz
2008-12-13 23:39 ` [PATCH 5/6] ide: use lock bitops for ports serialization Bartlomiej Zolnierkiewicz
2008-12-13 23:40 ` [PATCH 6/6] ide: merge ide_hwgroup_t with ide_hwif_t Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216202436.GA2506@1wt.eu \
--to=w@1wt.eu \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.