From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV
Date: Wed, 17 Dec 2008 08:03:15 +0000 [thread overview]
Message-ID: <20081217080315.GZ28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20081216235656.d7985f1d.akpm@linux-foundation.org>
On Tue, Dec 16, 2008 at 11:56:56PM -0800, Andrew Morton wrote:
> > + if (copy_from_user(&ts, u_abs_timeout,
> > + sizeof(struct timespec)))
>
> Well that's odd. afacit timespec has different sizes on 32-bit and
> 64-bit userspace.
>
> But the old audit code did this copy too, and it presumably worked.
compat_mq_timedsend() et.al. essentially do copy_in_user() converting to
64bit and theh call sys_mq_...(). So you get kernel-native layout in
the log.
Similar for notification in compat_mq_notify(), etc.
prev parent reply other threads:[~2008-12-17 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 5:12 [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV Al Viro
2008-12-17 7:40 ` James Morris
2008-12-17 9:40 ` Al Viro
2008-12-17 7:56 ` Andrew Morton
2008-12-17 8:03 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217080315.GZ28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.