From: "Shawn O. Pearce" <spearce@spearce.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-gui: Get rid of the last remnants of GIT_CONFIG_LOCAL
Date: Wed, 17 Dec 2008 07:53:09 -0800 [thread overview]
Message-ID: <20081217155309.GA32487@spearce.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0812142311360.25197@racer>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>
> In dc871831(Only use GIT_CONFIG in "git config", not other programs),
> GIT_CONFIG_LOCAL was rested in peace, in favor of not reading
> /etc/gitconfig and $HOME/.gitconfig at all when GIT_CONFIG is set.
>
> You might want to hold off on that, as git-gui is supposed to be
> less tightly coupled to git.git than, say, git-svn.
>
> The commit removing support for GIT_CONFIG_LOCAL is from Mon Jun
> 30 03:37:47 2008 -0400...
Nah, that's in Git 1.6.0. This block of code is only useful on
Windows, where most people are probably running a more msysgit
style system than some random mashup of Git and git-gui versions.
Plus, wasn't there just some discussion about how this warning
is perhaps harmful to the user because it doesn't really help
her to resolve the problem?
I applied it anyway. Its quite unlikely anyone runs git-gui on
Windows with GIT_CONFIG_LOCAL in their environment.
--
Shawn.
next prev parent reply other threads:[~2008-12-17 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-14 22:10 [PATCH] Get rid of the last remnants of GIT_CONFIG_LOCAL Johannes Schindelin
2008-12-14 22:12 ` [PATCH] git-gui: " Johannes Schindelin
2008-12-17 15:53 ` Shawn O. Pearce [this message]
2008-12-15 0:43 ` [PATCH] " Junio C Hamano
2008-12-15 9:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217155309.GA32487@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.