All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Bob Copeland <bcopeland@gmail.com>
Cc: Benoit PAPILLAULT <benoit.papillault@free.fr>,
	Jouni Malinen <j@w1.fi>,
	linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100%
Date: Wed, 17 Dec 2008 10:55:34 -0500	[thread overview]
Message-ID: <20081217155533.GB12679@tuxdriver.com> (raw)
In-Reply-To: <b6c5339f0812160722nab8516cj1ed4e6d397060d9d@mail.gmail.com>

On Tue, Dec 16, 2008 at 10:22:39AM -0500, Bob Copeland wrote:
> On Mon, Dec 15, 2008 at 4:06 PM, Benoit PAPILLAULT
> <benoit.papillault@free.fr> wrote:
> 
> > frames. To me, the bug we have seen when receiving a ACK frame in
> > monitor mode was not because "ACK is a small control frame", it was
> > because the header length we computed was smaller than what the hardware
> > considered.
> 
> It's because data frames have a payload and ACKs do not.
> 
> > To reply to Bob as well, we need to compute the number of padded bytes +
> > the position at which the padding occurs, so proper "header" length is
> > required.
> 
> Well, anyway John already picked up your earlier (better, IMHO) patch.
> Now we just need to fix the tx descriptors :)

Based on that comment, I'm dropping this version of the patch.
Feel free to submit additional patches to implement whatever might
be missing now.

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.

  parent reply	other threads:[~2008-12-17 16:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-15 14:34 [PATCH] ath5k: Updated padding stuff for the RX and TX side. TX side has been 100% Benoit Papillault
2008-12-15 17:06 ` Jouni Malinen
2008-12-15 21:06   ` Benoit PAPILLAULT
2008-12-16 15:22     ` Bob Copeland
2008-12-16 15:42       ` Bob Copeland
2008-12-17 15:55       ` John W. Linville [this message]
2008-12-17 17:40         ` Bob Copeland
2008-12-17 18:35           ` John W. Linville
2008-12-19 15:53             ` Bob Copeland
2008-12-15 17:07 ` Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081217155533.GB12679@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=ath5k-devel@venema.h4ckr.net \
    --cc=bcopeland@gmail.com \
    --cc=benoit.papillault@free.fr \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.