All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: iommu@lists.linux-foundation.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86 gart: don't complain if no AMD GART found
Date: Wed, 17 Dec 2008 21:53:08 +0100	[thread overview]
Message-ID: <20081217205308.GA11528@amd.com> (raw)
In-Reply-To: <20081217195234.13603.96737.stgit@bob.kio>

On Wed, Dec 17, 2008 at 12:52:34PM -0700, Bjorn Helgaas wrote:
> It's perfectly normal for no AMD GART to be present, e.g., if you have
> Intel CPUs.  None of the other iommu_init() functions makes noise when
> it finds nothing.

True, there are even 64bit AMD processors without GART.

Ingo,

do you want to pick this patch up or should I do it?

> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

Acked-by: Joerg Roedel <joerg.roedel@amd.com>

> ---
>  arch/x86/kernel/pci-gart_64.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
> index ba7ad83..a35eaa3 100644
> --- a/arch/x86/kernel/pci-gart_64.c
> +++ b/arch/x86/kernel/pci-gart_64.c
> @@ -745,10 +745,8 @@ void __init gart_iommu_init(void)
>  	unsigned long scratch;
>  	long i;
>  
> -	if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0) {
> -		printk(KERN_INFO "PCI-GART: No AMD GART found.\n");
> +	if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0)
>  		return;
> -	}
>  
>  #ifndef CONFIG_AGP_AMD64
>  	no_agp = 1;
> 
> 

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


  parent reply	other threads:[~2008-12-17 20:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17 19:52 [PATCH] x86 gart: don't complain if no AMD GART found Bjorn Helgaas
2008-12-17 20:27 ` Dave Jones
2008-12-18 16:49   ` Bjorn Helgaas
2008-12-19  0:12   ` Muli Ben-Yehuda
2008-12-17 20:53 ` Joerg Roedel [this message]
2008-12-18 12:26   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081217205308.GA11528@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=hpa@zytor.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.