From: Ingo Molnar <mingo@elte.hu>
To: Ken Chen <kenchen@google.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] x86: convert rdtscll() to use __native_read_tsc
Date: Thu, 18 Dec 2008 14:31:34 +0100 [thread overview]
Message-ID: <20081218133134.GH32135@elte.hu> (raw)
In-Reply-To: <b040c32a0812170007s59600707h5a8597a1cbe9cc21@mail.gmail.com>
* Ken Chen <kenchen@google.com> wrote:
> On Tue, Dec 16, 2008 at 2:15 AM, Ingo Molnar <mingo@elte.hu> wrote:
> > agreed mostly, with this twist: vdso inlining dependencies should be
> > expressed explicitly, via:
> >
> > native_vread_tsc()
> >
> > but we can also make native_read_tsc() __always_inline [it's a single
> > instruction with basically no preparatory halo around that instruction]
> > and document the vdso detail there.
>
> Given that vdso already uses the inline version of __native_read_tsc, we
> don't really have churn all that code around. I also take your analysis
> as there is no issue in converting rdtscll() to __native_read_tsc().
> Would it be possible for you to merge the patch then?
yep, i already did that when i replied to your mail, it's in tip/x86/time.
Ingo
prev parent reply other threads:[~2008-12-18 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 8:32 [patch] x86: convert rdtscll() to use __native_read_tsc Ken Chen
2008-12-16 9:15 ` Ingo Molnar
2008-12-16 9:26 ` Jeremy Fitzhardinge
2008-12-16 10:15 ` Ingo Molnar
2008-12-17 8:07 ` Ken Chen
2008-12-18 13:31 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218133134.GH32135@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.