Re: [PATCH v2 1/3] cfg80211: add PM hooks

["John W. Linville" <linville@tuxdriver.com>]

On Wed, Dec 17, 2008 at 07:10:49PM +0100, Johannes Berg wrote:
> On Wed, 2008-12-17 at 10:35 -0500, John W. Linville wrote:
> > On Sun, Dec 14, 2008 at 10:50:37PM -0500, Bob Copeland wrote:
> > > From: Johannes Berg <johannes@sipsolutions.net>
> > > 
> > > This should help implement suspend/resume in mac80211, these
> > > hooks will be run before the device is suspended and after it
> > > resumes. Therefore, they can touch the hardware as much as
> > > they want to.
> > > 
> > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > 
> > Is cfg80211 the right place for these?  Is it likely that any
> > non-mac80211 users of cfg80211 will ever want to use these hooks?
> 
> That's a good question. But even if non-mac80211 won't use this, I don't
> see how to get notifications in mac80211 w/o involving cfg80211, since
> mac80211 doesn't really have a way to get at the ops there without this,
> does it?

No, I suppose not.

I'm not too familiar with the internals of the PM stuff.  Is there
any guarantee that the cfg80211 suspend stuff will run before the
bus-specific suspend stuff?  Is this a concern?

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.