All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Kirby <sim@netnation.com>
To: Jan Kara <jack@suse.cz>,
	Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
	Mike Snitzer <snitzer@gmail.com>,
	Andreas Dilger <adilger@sun.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: EXT3 way too happy with write errors
Date: Thu, 18 Dec 2008 09:49:22 -0800	[thread overview]
Message-ID: <20081218174921.GF20515@hostway.ca> (raw)
In-Reply-To: <20081218172759.GE13580@duck.suse.cz>

[ You guys were on this original thread.. ]

Re: http://markmail.org/message/jcku5vo5grcjjd3s#query:+page:1+mid:ws2wkcj66ucozlnd+state:results

Maybe you could explain why on earth would you want this configurable?

I think it's a horrible idea to make the default to ignore write errors,
and still a bad idea to even make this an option.  Do people really want
data corruption and a log message rather than a a clean way to recover
from such an error, depending on the cause of it?

Aborting on data write error: User can fix why it can't write (maybe the
bus just went to lunch), remount-rw or reboot and the journal will replay
and the file system will be consistent, data and metadata, just as if the
power had failed.

Not aborting on data write error: User loses data.  File system gets very
confused.

What am I missing?

Simon-

On Thu, Dec 18, 2008 at 06:27:59PM +0100, Jan Kara wrote:

> On Thu 18-12-08 09:18:25, Simon Kirby wrote:
> 
> > Cool, but one question.. Can you think of a case where anyone would ever
> > want data_err=ignore?
> > 
> > Should this really be a knob?
>
>   Originally, we changed the behavior unconditionally but then someone came
> up with some reasonable argument why it should be tunable. I don't remember
> it exactly, sorry :).
> 
> 									Honza

  reply	other threads:[~2008-12-18 17:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15  0:22 EXT3 way too happy with write errors Simon Kirby
2008-12-18 17:07 ` Jan Kara
2008-12-18 17:18   ` Simon Kirby
2008-12-18 17:27     ` Jan Kara
2008-12-18 17:49       ` Simon Kirby [this message]
2008-12-18 18:29         ` Michael Rubin
2009-01-03  2:15           ` Simon Kirby
2009-01-03  2:45             ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081218174921.GF20515@hostway.ca \
    --to=sim@netnation.com \
    --cc=adilger@sun.com \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=snitzer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.