From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Balaji Rao <balajirrao@openmoko.org>
Cc: linux-kernel@vger.kernel.org, Andy Green <andy@openmoko.com>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH V2 4/7] rtc: PCF50633 rtc driver
Date: Thu, 18 Dec 2008 17:52:14 +0100 [thread overview]
Message-ID: <20081218175214.3550dfdd@i1501.lan.towertech.it> (raw)
In-Reply-To: <20081218151142.GA2284@cff.thadambail>
On Thu, 18 Dec 2008 20:41:43 +0530
Balaji Rao <balajirrao@openmoko.org> wrote:
> > + pcf50633_free_irq(rtc->pcf, PCF50633_IRQ_ALARM);
> > > + pcf50633_free_irq(rtc->pcf, PCF50633_IRQ_SECOND);
> >
> > please remove rtc before unregistering
> >
>
> Sorry, didn't get you meant.
>
> Thank you for the review.
my fault. s/rtc/irq/
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2008-12-18 16:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 5:56 [PATCH V2 0/7] PCF50633 support Balaji Rao
2008-12-18 5:56 ` [PATCH V2 1/7] mfd: PCF50633 core driver Balaji Rao
2008-12-18 5:56 ` [PATCH V2 2/7] mfd: PCF50633 adc driver Balaji Rao
2008-12-19 11:18 ` Jonathan Cameron
2008-12-19 12:05 ` Mark Brown
2008-12-19 12:47 ` Jonathan Cameron
2008-12-19 12:15 ` Andy Green
2008-12-19 12:51 ` Jonathan Cameron
2008-12-22 16:23 ` Balaji Rao
2008-12-18 5:57 ` [PATCH V2 3/7] mfd: PCF50633 gpio support Balaji Rao
2008-12-18 5:57 ` [PATCH V2 4/7] rtc: PCF50633 rtc driver Balaji Rao
2008-12-18 9:03 ` Alessandro Zummo
2008-12-18 15:11 ` Balaji Rao
2008-12-18 16:52 ` Alessandro Zummo [this message]
2008-12-18 5:57 ` [PATCH V2 5/7] power_supply: PCF50633 battery charger driver Balaji Rao
2008-12-18 20:26 ` Balaji Rao
2008-12-25 15:45 ` Anton Vorontsov
2008-12-25 18:50 ` Balaji Rao
2008-12-18 5:58 ` [PATCH V2 6/7] input: PCF50633 input driver Balaji Rao
2008-12-18 5:58 ` [PATCH V2 7/7] regulator: PCF50633 pmic driver Balaji Rao
2008-12-18 10:08 ` Mark Brown
2008-12-18 15:14 ` Balaji Rao
2008-12-18 20:30 ` Liam Girdwood
2008-12-18 20:47 ` Balaji Rao
2008-12-18 20:54 ` Liam Girdwood
2008-12-22 10:50 ` [PATCH V2 0/7] PCF50633 support Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218175214.3550dfdd@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=a.zummo@towertech.it \
--cc=andy@openmoko.com \
--cc=balajirrao@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.