From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
"Helight.Xu" <helight.xu@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix some code style that line over 80 characters
Date: Thu, 18 Dec 2008 19:30:59 +0000 [thread overview]
Message-ID: <20081218193059.GA31274@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20081218112617.09fd97bd.randy.dunlap@oracle.com>
On Thu, Dec 18, 2008 at 11:26:17AM -0800, Randy Dunlap wrote:
> On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:
>
> > On Wed, Dec 10, 2008 at 09:51:43PM +0800, Helight.Xu wrote:
> > > -static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> > > +static inline struct
> > > +s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
> >
> > NAK!
>
> OK, but please includes reason(s) for NAKs...
I can provide a reason - it splits "struct" and the structure name
across different lines. That manes 'struct s3c2410_platform_i2c'
hard to grep for.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-12-18 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 13:51 [PATCH] fix some code style that line over 80 characters Helight.Xu
2008-12-10 15:01 ` Alexey Dobriyan
2008-12-11 7:20 ` Zhenwen Xu
2008-12-18 19:26 ` Randy Dunlap
2008-12-18 19:30 ` Russell King [this message]
2008-12-19 6:34 ` Zhenwen Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218193059.GA31274@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=adobriyan@gmail.com \
--cc=helight.xu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.