All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Magnus Damm" <magnus.damm@gmail.com>,
	linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] clocksource: pass clocksource to read() callback
Date: Fri, 19 Dec 2008 00:11:21 -0800	[thread overview]
Message-ID: <20081219001121.bf985802.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081218234725.4126d858.akpm@linux-foundation.org>

On Thu, 18 Dec 2008 23:47:25 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 19 Dec 2008 16:30:36 +0900 "Magnus Damm" <magnus.damm@gmail.com> wrote:
> 
> > >  CHK     include/linux/version.h
> > >  CHK     include/linux/utsrelease.h
> > >  SYMLINK include/asm -> include/asm-sparc
> > >  CC      arch/sparc/kernel/asm-offsets.s
> > > In file included from include/linux/ktime.h:25,
> > >                 from include/linux/timer.h:5,
> > >                 from include/linux/clocksource.h:16,
> > >                 from /usr/src/devel/arch/sparc/include/asm/timer_64.h:11,
> > >                 from /usr/src/devel/arch/sparc/include/asm/timer.h:4,
> > >                 from /usr/src/devel/arch/sparc/include/asm/timex_64.h:9,
> > >                 from /usr/src/devel/arch/sparc/include/asm/timex.h:4,
> > >                 from include/linux/timex.h:170,
> > >                 from include/linux/sched.h:54,
> > >                 from arch/sparc/kernel/asm-offsets.c:13:
> > > include/linux/jiffies.h:247:31: warning: "CLOCK_TICK_RATE" is not defined
> > [lot's of warning snipped]
> > 
> > How about the (unfortunately most likely mangled) patch below? Does it
> > help?
> 
> yup.

It still blows up though.  Any call to get_cycles() goes:

crypto/tcrypt.c: In function `test_cipher_cycles':
crypto/tcrypt.c:107: error: too few arguments to function
crypto/tcrypt.c:112: error: too few arguments to function
crypto/tcrypt.c: In function `test_hash_cycles_digest':
crypto/tcrypt.c:305: error: too few arguments to function
crypto/tcrypt.c:311: error: too few arguments to function
crypto/tcrypt.c: In function `test_hash_cycles':
crypto/tcrypt.c:361: error: too few arguments to function
crypto/tcrypt.c:375: error: too few arguments to function

because this:

arch/sparc/include/asm/timex_64.h:#define get_cycles()  tick_ops->get_tick()

needs help.

  reply	other threads:[~2008-12-19  8:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 11:48 [PATCH] clocksource: pass clocksource to read() callback Magnus Damm
2008-12-11 17:01 ` John Stultz
2008-12-12  9:57   ` Magnus Damm
2008-12-18  1:56 ` Andrew Morton
2008-12-19  7:30   ` Magnus Damm
2008-12-19  7:47     ` Andrew Morton
2008-12-19  8:11       ` Andrew Morton [this message]
2008-12-19 10:02         ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081219001121.bf985802.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.