From: Matt Kraai <kraai@ftbfs.org>
To: Wu Fengguang <fengguang.wu@intel.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-send-email: handle email address with quoted comma
Date: Thu, 18 Dec 2008 22:38:06 -0800 [thread overview]
Message-ID: <20081219063806.GA5425@ftbfs.org> (raw)
Howdy,
> +sub split_addrs($) {
> + my ($addrs) = @_;
> +
> + return "ewords('\s*,\s*', 1, $addrs);
> +}
> +
According to the documentation of Text::ParseWords,
The &*quotewords() functions simply call &parse_line(), so if you're
only splitting one line you can call &parse_line() directly and save
a function call.
so quotewords could be replaced by parse_line. I don't know if that's
less readable, though.
--
Matt http://ftbfs.org/
next reply other threads:[~2008-12-19 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 6:38 Matt Kraai [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-19 3:40 [PATCH] git-send-email: handle email address with quoted comma Wu Fengguang
2008-12-19 6:40 ` Junio C Hamano
2008-12-19 8:10 ` Wu Fengguang
2008-12-19 16:28 ` Matt Kraai
2008-12-20 20:09 ` Junio C Hamano
2008-12-20 6:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081219063806.GA5425@ftbfs.org \
--to=kraai@ftbfs.org \
--cc=fengguang.wu@intel.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.