From: Rusty Russell <rusty@rustcorp.com.au>
To: Dave Jones <davej@redhat.com>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Jan Engelhardt <jengelh@medozas.de>,
David Miller <davem@davemloft.net>,
ajax@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] net: Remove a noisy printk
Date: Fri, 19 Dec 2008 11:51:54 +1030 [thread overview]
Message-ID: <200812191151.55607.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20081214200353.GA2994@redhat.com>
On Monday 15 December 2008 06:33:53 Dave Jones wrote:
> On Sun, Dec 14, 2008 at 06:09:17PM +0100, Jozsef Kadlecsik wrote:
> > In a >normal< system one usually does not use raw sockets. So if a root
> > process do use raw socket, at least netfilter sends a notification and
> > there's a chance that someone take notice it by checking the kernel logs.
>
> 'normal' systems are irrelevant here. This message is triggerable remotely.
I don't think it can be. This is for truncated locally-generated outgoing
packets, which can only happen when root is playing with raw sockets.
As you can probably tell, I was the one who wrote this printk :) IMHO,
one reasonable complaint is sufficient to have it removed, so just remove
it. If anyone thinks it's valuable, put a static counter < 5 around it
and add pid/comm info.
Cheers,
Rusty.
next prev parent reply other threads:[~2008-12-19 1:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 22:13 [PATCH] net: Remove a noisy printk Adam Jackson
2008-12-11 22:13 ` [PATCH] ACPI: Silence blacklist warnings Adam Jackson
2008-12-11 22:13 ` [PATCH] x86: Don't print error for lack of i8042 chip Adam Jackson
2008-12-11 22:13 ` [PATCH] PCI: Don't carp about BAR allocation failures in quiet boot Adam Jackson
2008-12-11 22:26 ` [PATCH] net: Remove a noisy printk Sam Ravnborg
2008-12-12 4:32 ` David Miller
2008-12-13 22:13 ` Jan Engelhardt
2008-12-14 17:09 ` Jozsef Kadlecsik
2008-12-14 18:06 ` Jan Engelhardt
2008-12-14 20:15 ` Jozsef Kadlecsik
2008-12-15 12:23 ` Patrick McHardy
2008-12-15 13:25 ` Jozsef Kadlecsik
2008-12-15 13:32 ` Patrick McHardy
2008-12-14 20:03 ` Dave Jones
2008-12-16 19:59 ` Jozsef Kadlecsik
2008-12-16 20:03 ` Jan Engelhardt
2008-12-16 20:00 ` Jan Engelhardt
2008-12-17 8:26 ` Jozsef Kadlecsik
2008-12-19 1:21 ` Rusty Russell [this message]
2009-01-12 5:02 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812191151.55607.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ajax@redhat.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.