From: Stephen Hemminger <shemminger@vyatta.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH RFC] pkt_sched: Remove smp_wmb() in qdisc_watchdog()
Date: Fri, 19 Dec 2008 18:18:51 -0800 [thread overview]
Message-ID: <20081219181851.7cda3fc1@extreme> (raw)
In-Reply-To: <20081219114125.GB17826@ff.dom.local>
On Fri, 19 Dec 2008 11:41:25 +0000
Jarek Poplawski <jarkao2@gmail.com> wrote:
> On Fri, Dec 19, 2008 at 11:30:47AM +0000, Jarek Poplawski wrote:
> ...
> > While implementing a TCQ_F_THROTTLED flag there was used an smp_wmb()
> > in qdisc_watchdog(), but since this flag is practically used only in
> > sch_netem(), and since it's not even clear what reordering is avoided
>
> Hmm.. I forgot to mention sch_cbq(), but it doesn't use a barrier
> anyway.
>
> Jarek P.
The barrier was copied from earlier version of tbf is unnecessary.
next prev parent reply other threads:[~2008-12-20 2:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 11:30 [PATCH RFC] pkt_sched: Remove smp_wmb() in qdisc_watchdog() Jarek Poplawski
2008-12-19 11:41 ` Jarek Poplawski
2008-12-20 2:18 ` Stephen Hemminger [this message]
2008-12-22 7:57 ` [PATCH v2] " Jarek Poplawski
2008-12-23 3:44 ` [PATCH RFC] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081219181851.7cda3fc1@extreme \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.