From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: xfstests tests not in the auto group; do we know why?
Date: Sat, 20 Dec 2008 16:10:15 +1100 [thread overview]
Message-ID: <20081220051015.GE17177@disturbed> (raw)
In-Reply-To: <20081219214411.GA18003@infradead.org>
On Fri, Dec 19, 2008 at 04:44:12PM -0500, Christoph Hellwig wrote:
> > 104 hangs ...
>
> Yeah, we should fix this eventually :)
Changing the locking in growfs to loop doing trylocks
will prevent the deadlock. Might take a long time to get the
lock though....
> > # auto - tests to be run as part of nightly qa
> >
> > I'm not sure what that means; is this group always supposed to pass? If
> > so there are filestreams tests that don't, for example. Maybe "tests
> > that don't hang?"
> >
> > I wonder if it'd be worth documenting this a bit, and have a group which
> > should always run & pass on the core architectures. (and for those that
> > don't pass, do a bit of documentation on why they don't?)
>
> I think that would be auto. I'm all for a slight reshuffling of the
> groups:
>
> auto - stuff that should succeed everywhere
> large - stuff that needs a large enough machine / fs to succeed
> (for whatever defintion of large)
> xfail - expected to fail
> xhang - expected to hang
> (should be empty normally, only for new testcases)
I'd say we should add another:
fast - tests that complete in only a few seconds
so that we can run a quicker set of sanity checks while developing
stuff. The current auto run takes a couple of hours under UML, which
means a qa cycle doesn't keep up with the rate at which I want to
test new changes......
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-20 5:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 5:01 xfstests tests not in the auto group; do we know why? Eric Sandeen
2008-12-19 21:44 ` Christoph Hellwig
2008-12-20 5:10 ` Dave Chinner [this message]
2008-12-20 5:50 ` Eric Sandeen
2008-12-20 5:52 ` Eric Sandeen
2008-12-20 6:01 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081220051015.GE17177@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.