From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] sh: maple: add Maple controller as a joystick device Date: Sat, 20 Dec 2008 12:28:20 -0800 Message-ID: <200812201228.20767.dmitry.torokhov@gmail.com> References: <1229797614.6502.20.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: base64 Return-path: Received: from yx-out-2324.google.com ([74.125.44.30]:7429 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753077AbYLTU2n (ORCPT ); Sat, 20 Dec 2008 15:28:43 -0500 In-Reply-To: <1229797614.6502.20.camel@localhost.localdomain> Content-Disposition: inline Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Adrian McMenamin Cc: LKML , linux-sh , linux-input , Paul Mundt , Andrew Morton T24gU2F0dXJkYXkgMjAgRGVjZW1iZXIgMjAwOCAxMDoyNjo1NCBBZHJpYW4gTWNNZW5hbWluIHdy b3RlOgo+ICugoKCgoKCgbWRldiA9IHRvX21hcGxlX2RldihkZXYpOwo+ICugoKCgoKCgaWYgKCFt ZGV2KSB7Cj4gK6CgoKCgoKCgoKCgoKCgoGVycm9yID0gRUlOVkFMOwo+ICugoKCgoKCgoKCgoKCg oKBnb3RvIGZhaWw7Cj4gK6CgoKCgoKB9Cj4gK6CgoKCgoKAKPiAroKCgoKCgoG1kcnYgPSB0b19t YXBsZV9kcml2ZXIoZGV2LT5kcml2ZXIpOwo+ICugoKCgoKCgaWYgKCFtZHJ2KSB7Cj4gK6CgoKCg oKCgoKCgoKCgoGVycm9yID0gRUlOVkFMOwo+ICugoKCgoKCgoKCgoKCgoKBnb3RvIGZhaWw7Cj4g K6CgoKCgoKB9CgpUaGlzIHdpbGwgbmV2ZXIgaGFwcGVuIC0gdG9fbWFwbGVfKiBhcmUgc2ltcGxl IHdyYXBwZXJzIGFyb3VuZCBjb250YWluZXJfb2YgCmFuZCBzbyB0aGUgcmVzdWx0IHdpbGwgbmV2 ZXIgYmUgTlVMTCBidXQgc29tZSBzbWFsbCBvZmZzZXQgZnJvbSBpdCBpZiBkZXYgaXMgCk5VTEwu IEknbSBzdGF5aW5nIG9uIHRoZSBvbGQgdmVyc2lvbiBvZiB0aGUgcGF0Y2ggd2l0aCBzbWFsbCBm aXh1cHMuCgotLSAKRG1pdHJ5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Date: Sat, 20 Dec 2008 20:28:20 +0000 Subject: Re: [PATCH] sh: maple: add Maple controller as a joystick device Message-Id: <200812201228.20767.dmitry.torokhov@gmail.com> List-Id: References: <1229797614.6502.20.camel@localhost.localdomain> In-Reply-To: <1229797614.6502.20.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: Adrian McMenamin Cc: LKML , linux-sh , linux-input , Paul Mundt , Andrew Morton T24gU2F0dXJkYXkgMjAgRGVjZW1iZXIgMjAwOCAxMDoyNjo1NCBBZHJpYW4gTWNNZW5hbWluIHdy b3RlOgo+ICugoKCgoKCgbWRldiA9IHRvX21hcGxlX2RldihkZXYpOwo+ICugoKCgoKCgaWYgKCFt ZGV2KSB7Cj4gK6CgoKCgoKCgoKCgoKCgoGVycm9yID0gRUlOVkFMOwo+ICugoKCgoKCgoKCgoKCg oKBnb3RvIGZhaWw7Cj4gK6CgoKCgoKB9Cj4gK6CgoKCgoKAKPiAroKCgoKCgoG1kcnYgPSB0b19t YXBsZV9kcml2ZXIoZGV2LT5kcml2ZXIpOwo+ICugoKCgoKCgaWYgKCFtZHJ2KSB7Cj4gK6CgoKCg oKCgoKCgoKCgoGVycm9yID0gRUlOVkFMOwo+ICugoKCgoKCgoKCgoKCgoKBnb3RvIGZhaWw7Cj4g K6CgoKCgoKB9CgpUaGlzIHdpbGwgbmV2ZXIgaGFwcGVuIC0gdG9fbWFwbGVfKiBhcmUgc2ltcGxl IHdyYXBwZXJzIGFyb3VuZCBjb250YWluZXJfb2YgCmFuZCBzbyB0aGUgcmVzdWx0IHdpbGwgbmV2 ZXIgYmUgTlVMTCBidXQgc29tZSBzbWFsbCBvZmZzZXQgZnJvbSBpdCBpZiBkZXYgaXMgCk5VTEwu IEknbSBzdGF5aW5nIG9uIHRoZSBvbGQgdmVyc2lvbiBvZiB0aGUgcGF0Y2ggd2l0aCBzbWFsbCBm aXh1cHMuCgotLSAKRG1pdHJ5Cv/06Lp7Lm7HK4m3n66JrYYrJYrL/7Hp3bYXpYp3/7p7Lm7HK4m3 pYp7sf7I/4p7YXm6HcqH2pnrLGoHraJmo6K3aJqP74Hq/5Hq53pf6K4DKK3pmo6K3aJqIp36GrYb baf//74Hq/5Hq53p/6K4P5mo6K3aJqP4p36P4Qo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754485AbYLTU2y (ORCPT ); Sat, 20 Dec 2008 15:28:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753316AbYLTU2o (ORCPT ); Sat, 20 Dec 2008 15:28:44 -0500 Received: from yx-out-2324.google.com ([74.125.44.30]:7429 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753077AbYLTU2n (ORCPT ); Sat, 20 Dec 2008 15:28:43 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=OqLR+KY7XZloodvFxDnRFRRzaGiM6RQmTeZrMZLpognBrOrjpWzIKhQapyiME0BVs0 2S5V80IBl7H9xwnXO46uEFHvfe2gSZP5JbU8aeXipVtngk671202rrhPt5FK4A3MWoWE /mwnxd0Khs1+6hG/IlyDoSCau5wRznlhkNtqo= From: Dmitry Torokhov To: Adrian McMenamin Subject: Re: [PATCH] sh: maple: add Maple controller as a joystick device Date: Sat, 20 Dec 2008 12:28:20 -0800 User-Agent: KMail/1.10.3 (Linux/2.6.27.7-134.fc10.x86_64; KDE/4.1.3; x86_64; ; ) Cc: LKML , "linux-sh" , "linux-input" , Paul Mundt , Andrew Morton References: <1229797614.6502.20.camel@localhost.localdomain> In-Reply-To: <1229797614.6502.20.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Disposition: inline Message-Id: <200812201228.20767.dmitry.torokhov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha id mBKKSvki028935 On Saturday 20 December 2008 10:26:54 Adrian McMenamin wrote:> +mdev = to_maple_dev(dev);> +if (!mdev) {> +error = EINVAL;> +goto fail;> +}> +> +mdrv = to_maple_driver(dev->driver);> +if (!mdrv) {> +error = EINVAL;> +goto fail;> +} This will never happen - to_maple_* are simple wrappers around container_of and so the result will never be NULL but some small offset from it if dev is NULL. I'm staying on the old version of the patch with small fixups. -- Dmitry{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I