From: Grant Grundler <grundler@parisc-linux.org>
To: Kyle McMartin <kyle@infradead.org>
Cc: Guy Martin <gmsoft@tuxicoman.be>, linux-parisc@vger.kernel.org
Subject: Re: HPMC bus timeout on C3600
Date: Sun, 21 Dec 2008 01:12:06 -0700 [thread overview]
Message-ID: <20081221081206.GC2047@colo.lackof.org> (raw)
In-Reply-To: <20081220222100.GB12880@bombadil.infradead.org>
On Sat, Dec 20, 2008 at 05:21:00PM -0500, Kyle McMartin wrote:
> On Sat, Dec 20, 2008 at 05:16:53PM -0500, Kyle McMartin wrote:
> > you can try hacking elroy to set softfail mode on that bus, which will
> > result in a timeout on the pci bus to return -1 (like what x86 and most
> > other architectures do) rather than hang the box, but it really likely
> > means a driver bug.
>
> untested and all that jazz.
>
> diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
> index a28c894..a34f759 100644
> --- a/drivers/parisc/lba_pci.c
> +++ b/drivers/parisc/lba_pci.c
> @@ -1341,7 +1341,7 @@ lba_hw_init(struct lba_device *d)
>
> /* Set HF mode as the default (vs. -1 mode). */
> stat = READ_REG32(d->hba.base_addr + LBA_STAT_CTL);
> - WRITE_REG32(stat | HF_ENABLE, d->hba.base_addr + LBA_STAT_CTL);
> + WRITE_REG32(stat & ~HF_ENABLE, d->hba.base_addr + LBA_STAT_CTL);
I'm not sure how helpful this will be. It will be unpredictable how
the tulip driver will handle getting -1's back from inw().
thanks,
grant
>
> /*
> ** Writing a zero to STAT_CTL.rf (bit 0) will clear reset signal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-12-21 8:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-20 12:39 HPMC bus timeout on C3600 Guy Martin
2008-12-20 22:16 ` Kyle McMartin
2008-12-20 22:21 ` Kyle McMartin
2008-12-21 8:12 ` Grant Grundler [this message]
2008-12-22 21:40 ` Guy Martin
2008-12-22 21:47 ` Kyle McMartin
2008-12-22 22:49 ` Guy Martin
2008-12-25 8:06 ` Grant Grundler
2008-12-25 15:57 ` Guy Martin
2008-12-25 21:36 ` Grant Grundler
2009-01-02 20:46 ` Guy Martin
2009-01-02 21:01 ` Kyle McMartin
2009-01-02 21:14 ` John David Anglin
2009-01-02 21:18 ` Kyle McMartin
2009-01-02 21:36 ` John David Anglin
2009-01-03 0:09 ` John David Anglin
2009-01-03 0:44 ` Kyle McMartin
2009-01-03 1:24 ` John David Anglin
2009-01-03 1:27 ` Kyle McMartin
2008-12-21 8:10 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081221081206.GC2047@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=gmsoft@tuxicoman.be \
--cc=kyle@infradead.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.