All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: Frans Pop <elendil@planet.nl>,
	tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hrtimer: increase clock min delta threshold while interrupt hanging
Date: Mon, 22 Dec 2008 10:05:45 +0100	[thread overview]
Message-ID: <20081222090545.GA2064@elte.hu> (raw)
In-Reply-To: <c62985530812220100m775c2e5ek5889f7891e4c1f4d@mail.gmail.com>


* Frédéric Weisbecker <fweisbec@gmail.com> wrote:

> > Also, there's min_delta doubling in tick_dev_program_event() itself 
> > too - that interacts with the irq-overload logic:
> >
> > +       dev->min_delta_ns = (unsigned long)try_time.tv64 * 3;
> >
> >        Ingo
> 
> That's what I explained above, the doubling of min delta in 
> tick_dev_program_event() is never reached in my case. And moreover I'm 
> not sure it is ever reached whatever the call sites of 
> tick_dev_program_event() unless min delta has a very low value...

yeah, that looks all rather messy and probably ineffective. Thomas, mind 
to take a look?

Frederic's patch solves a real timer-irq-overload extreme situation so i 
find it rather valuable. Maybe we should do Frederic's patch as-is, have 
the 'softer' min_delta behavior for the usual hrtimer codepaths - and the 
more agressive one for the timer tick only?

	Ingo

  reply	other threads:[~2008-12-22  9:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-22  1:24 [PATCH] hrtimer: increase clock min delta threshold while interrupt hanging Frederic Weisbecker
2008-12-22  2:07 ` Frans Pop
2008-12-22  7:00   ` Ingo Molnar
2008-12-22  9:00     ` Frédéric Weisbecker
2008-12-22  9:05       ` Ingo Molnar [this message]
2008-12-22  9:24         ` Frédéric Weisbecker
2008-12-22  9:04   ` Frédéric Weisbecker
2008-12-22 20:41     ` Frans Pop
2008-12-22 15:17 ` Cyrill Gorcunov
2008-12-22 15:28   ` Frédéric Weisbecker
2008-12-27 10:53 ` Ingo Molnar
2008-12-27 14:00   ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081222090545.GA2064@elte.hu \
    --to=mingo@elte.hu \
    --cc=elendil@planet.nl \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.