All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <me@felipebalbi.com>
To: Kainan Cha <thezha@gmail.com>
Cc: me@felipebalbi.com, pramod gurav <pramodforum@gmail.com>,
	linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: I2C1 controller timed out issue
Date: Mon, 22 Dec 2008 18:03:02 +0200	[thread overview]
Message-ID: <20081222160302.GC17843@frodo> (raw)
In-Reply-To: <c236f0530812200935y1397d03bm54fe7f3714776b0@mail.gmail.com>

On Sat, Dec 20, 2008 at 11:35:51AM -0600, Kainan Cha wrote:
> Balbi,
> 
> I have also seen this issue once in a while but I am using 2.6.24 kernel. Do
> you know which commits in the linux-omap git fixes this issue so I can
> backport?

Hmm, I suppose it's this one:

commit 663715fc55ea5d292171c6934a2b91d8f4874171
Author: Paul Walmsley <paul@pwsan.com>
Date:   Fri Oct 10 10:58:30 2008 -0600

    i2c-omap: fix I2C timeouts due to recursive omap_i2c_{un,}idle()
    
    omap_i2c_unidle() and omap_i2c_idle() are called recursively during
    omap_i2c_probe().  This is evidently unexpected and will wipe
    out the I2C interrupt enable register the second time that
    omap_i2c_idle() is called consecutively.  Any I2C transactions
    following a probe of a bus with at least one device on it will then
    time out.
    
    Fix by moving omap_i2c_idle() further up in omap_i2c_probe().  Ensure
    the I2C controller is marked as idle before the probe starts.  Also
    attempt to catch future reappearances of this bug early in development
    by warning in omap_i2c_{un,}idle() when they are called recursively.
    
    Problem reported by David Brownell <david-b@pacbell.net>.
    
    Tested on 3430SDP and 2430SDP.

But I'd say the changes to twl4030-core.c also helped and those will be
nasty to backport :-p

-- 
balbi

  parent reply	other threads:[~2008-12-22 16:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-20 10:04 I2C1 controller timed out issue pramod gurav
2008-12-20 14:09 ` Felipe Balbi
2008-12-22  5:14   ` pramod gurav
     [not found]     ` <f502236f0812212114p4b20e81br52d9031c4673f886-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-12-22  5:22       ` pramod gurav
     [not found]         ` <f502236f0812212122x3cb45444ld30c5e56d3546726-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-12-22  7:26           ` David Brownell
     [not found]   ` <c236f0530812200935y1397d03bm54fe7f3714776b0@mail.gmail.com>
2008-12-22 16:03     ` Felipe Balbi [this message]
2008-12-22 16:07       ` Kainan Cha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081222160302.GC17843@frodo \
    --to=me@felipebalbi.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pramodforum@gmail.com \
    --cc=thezha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.