From: Sam Ravnborg <sam@ravnborg.org>
To: sparclinux@vger.kernel.org
Subject: Re: Unify module.*
Date: Mon, 22 Dec 2008 22:31:52 +0000 [thread overview]
Message-ID: <20081222223152.GC30716@uranus.ravnborg.org> (raw)
In-Reply-To: <20081222220745.GA30716@uranus.ravnborg.org>
>
> I think it should be safe to do:
>
> BUG_ON(((unsigned long)location >> (unsigned long)32) !> (unsigned long)0);
>
> As to my best understanding unsigned long
> is 32 bit on sparc32 and 64 bit on sparc64.
> So we should with the above code not get any warnings.
>
> But I did not really see the point of the BUG_ON in the first place,
> and my limited digging did not turn up when it was added.
>
> So to be safe I kept the ugly ifdef for now.
> If is easy to spot/remove.
And just tell me and I will respin the patch serie
with this or any other modifications requested.
Just to make sure this was explicitly stated.
Sam
next prev parent reply other threads:[~2008-12-22 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 22:07 Unify module.* Sam Ravnborg
2008-12-22 22:31 ` Sam Ravnborg [this message]
2008-12-22 22:34 ` Chris Torek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081222223152.GC30716@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.