From: Rusty Russell <rusty@rustcorp.com.au>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christopher Li <sparse@chrisli.org>, linux-sparse@vger.kernel.org
Subject: Re: Casting away noderef and address spaces?
Date: Tue, 23 Dec 2008 12:44:22 +1030 [thread overview]
Message-ID: <200812231244.22614.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20081222205750.GK28946@ZenIV.linux.org.uk>
On Tuesday 23 December 2008 07:27:50 Al Viro wrote:
> The right solution is
> (*(typeof(v) __attribute__((address_space(0), force)) *)(&v))
>
> Cast there will take a pointer to type of V and force-cast it to pointer to
> unqualified type of V. *(cast)&v will do the obvious thing. Will trim
> both the AS and noderef.
Thanks Al, that worked, but seems to tickle another bug (sparse 0.4.1, Ubuntu).
rusty@vivaldi:/tmp$ sparse foo.c
foo.c:11:20: warning: incorrect type in assignment (invalid types)
foo.c:11:20: expected unknown type 11<noident>
foo.c:11:20: got int
Here's my sample program now:
#define __percpu __attribute__((noderef, address_space(3)))
/* Turn v back into a normal var. */
#define convert(v) \
(*(typeof(v) __attribute__((address_space(0), force)) *)(&v))
int main(int argc, char *argv)
{
unsigned int __percpu x;
convert(x) = 0;
return 0;
}
next prev parent reply other threads:[~2008-12-23 2:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 5:36 Casting away noderef and address spaces? Rusty Russell
2008-12-22 20:06 ` Christopher Li
2008-12-22 20:57 ` Al Viro
2008-12-22 21:23 ` Christopher Li
2008-12-22 21:39 ` Al Viro
2008-12-22 22:33 ` Christopher Li
2008-12-22 22:42 ` Harvey Harrison
2008-12-22 22:57 ` Sam Ravnborg
2008-12-22 23:53 ` Alexey Zaytsev
2008-12-22 23:55 ` Johannes Berg
2008-12-23 0:20 ` Alexey Zaytsev
2008-12-23 0:35 ` Johannes Berg
2008-12-23 0:37 ` Johannes Berg
2008-12-23 1:25 ` Christopher Li
2008-12-23 9:59 ` Johannes Berg
2008-12-24 8:34 ` Christopher Li
2008-12-23 2:14 ` Rusty Russell [this message]
2008-12-23 3:02 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812231244.22614.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.