From: Ingo Molnar <mingo@elte.hu>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [Patch] signal: let valid_signal() check more
Date: Fri, 26 Dec 2008 09:56:54 +0100 [thread overview]
Message-ID: <20081226085654.GE755@elte.hu> (raw)
In-Reply-To: <20081226144928.GC3156@hack.private>
* Américo Wang <xiyou.wangcong@gmail.com> wrote:
> >> @@ -727,7 +727,7 @@ int vt_ioctl(struct tty_struct *tty, struct file * file,
> >> {
> >> if (!perm || !capable(CAP_KILL))
> >> goto eperm;
> >> - if (!valid_signal(arg) || arg < 1 || arg == SIGKILL)
> >> + if (!valid_signal((int)arg) || arg == SIGKILL)
> > ^^^^^
> >
> >The patch adds a lot of unnecessary typecasts like this.
>
> because it's inline?
Why does your patch add a lot of seemingly unnecessary typecasts? [if your
short reply was supposed to be an answer to that question then please
explain it in more detail.]
Ingo
next prev parent reply other threads:[~2008-12-26 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 1:26 [Patch] signal: let valid_signal() check more Américo Wang
2008-12-25 18:00 ` Oleg Nesterov
2008-12-26 14:49 ` Américo Wang
2008-12-26 8:56 ` Ingo Molnar [this message]
2008-12-26 17:16 ` Américo Wang
2008-12-26 16:06 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081226085654.GE755@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.