From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh <jaswinder@infradead.org>
Cc: x86 maintainers <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: reboot.c declare port_cf9_safe before they get used
Date: Sat, 27 Dec 2008 11:31:41 +0100 [thread overview]
Message-ID: <20081227103141.GF14639@elte.hu> (raw)
In-Reply-To: <1230049288.14358.4.camel@jaswinder.satnam>
* Jaswinder Singh <jaswinder@infradead.org> wrote:
> Impact: cleanup, avoid sparse warning
>
> Include "../pci/pci.h" for port_cf9_safe
>
> Fixes this sparse warning:
> arch/x86/kernel/reboot.c:43:6: warning: symbol 'port_cf9_safe' was not declared. Should it be static?
>
> Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
> ---
> arch/x86/kernel/reboot.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
applied to tip/x86/cleanups, thanks!
btw., this is ugly now:
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -22,6 +22,7 @@
> #endif
>
> #include <mach_ipi.h>
> +#include "../pci/pci.h"
could you send another patch that moves arch/x86/pci/pci.h to
arch/x86/include/asm/pci_x86.h (and update all the pci.h include sites)?
Ingo
next prev parent reply other threads:[~2008-12-27 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 16:21 [PATCH] x86: reboot.c declare port_cf9_safe before they get used Jaswinder Singh
2008-12-27 10:31 ` Ingo Molnar [this message]
2008-12-27 10:36 ` Jaswinder Singh Rajput
2008-12-29 8:43 ` Jaswinder Singh Rajput
2008-12-29 11:08 ` Ingo Molnar
2008-12-29 17:09 ` Jesse Barnes
2008-12-29 17:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081227103141.GF14639@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.