From: Andrew Morton <akpm@linux-foundation.org>
To: Nick Piggin <npiggin@suse.de>
Cc: ebiederm@xmission.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@elte.hu, ijc@hellion.org.uk
Subject: Re: early fixmap causes kmap breakage
Date: Mon, 29 Dec 2008 15:17:31 -0800 [thread overview]
Message-ID: <20081229151731.2a2c5a02.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081218211543.GB10681@wotan.suse.de>
On Thu, 18 Dec 2008 22:15:43 +0100
Nick Piggin <npiggin@suse.de> wrote:
> Hi,
>
> I've debugged a problem where i386+pae systems with more than a few CPUs
> blow up at boot in the kmap_atomic code.
ping?
> The problem is that the kmap_atomic pte pages all need to be contiguous
> memory because the pte is calculated via the first kmap pte page + an
> offset (so as not to have to walk the page tables every time).
>
> The fixmap setup code crudely allocates contiguous pte pages, which is fine,
> but if it finds an already populated pmd entry, then it will not switch it
> to a new, contiguous pte page. So the early fixmap introduces a discontig
> page table right in the middle of the kmap atomic fixmaps.
>
> Commenting out the eaarly fixmap setup in head_32.S gets everything working
> properly. What would be the best way to fix this? Could we put the early
> fixmap page table in initdata, and then have the fixmap setup proper first
> clear its corresponding pmd entry?
How come users/testers aren't reporting this?
next prev parent reply other threads:[~2008-12-29 23:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 21:15 early fixmap causes kmap breakage Nick Piggin
2008-12-29 23:17 ` Andrew Morton [this message]
2008-12-30 4:01 ` Nick Piggin
2008-12-30 6:13 ` Ingo Molnar
2008-12-30 7:54 ` Nick Piggin
2008-12-30 8:14 ` Nick Piggin
2008-12-30 10:28 ` Nick Piggin
2008-12-30 22:41 ` Eric W. Biederman
2008-12-31 1:54 ` Nick Piggin
2008-12-31 9:01 ` Eric W. Biederman
2008-12-31 9:33 ` Nick Piggin
2009-01-09 10:24 ` Ian Campbell
2008-12-30 6:22 ` Eric W. Biederman
2008-12-30 6:35 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081229151731.2a2c5a02.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=ijc@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.