diff for duplicates of <200812291947.52537.bzolnier@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 46f0590..a3f0357 100644 Binary files a/a/1.txt and b/N1/1.txt differ diff --git a/a/content_digest b/N1/content_digest index dcb2891..9013670 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -9,74 +9,12 @@ " Sergei Shtylyov <sshtylyov@ru.mvista.com>\0" "\00:1\0" "b\0" - "On Friday 19 December 2008, Bartlomiej Zolnierkiewicz wrote:\n" - "> On Thursday 18 December 2008, Mario Schwalbe wrote:\n" - "> > Resubmitted on request.\n" - "> > \n" - "> > According the documentation, id[ATA_ID_DWORD_IO] is non-zero if\n" - "> > the drive supports dword IO, while the code disables support by\n" - "> > setting IDE_DFLAG_NO_IO_32BIT. In addition, this word has been\n" - "> > reused by the ATA8 specification. This patch fixes both cases.\n" - "> > \n" - "> > Signed-off-by: Mario Schwalbe <schwalbe@inf.tu-dresden.de>\n" - "> > ---\n" - "> > drivers/ide/ide-probe.c | 2 +-\n" - "> > 1 files changed, 1 insertions(+), 1 deletions(-)\n" - "> > \n" - "> > diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c\n" - "> > index c55bdbd..859b0e5 100644\n" - "> > --- a/drivers/ide/ide-probe.c\n" - "> > +++ b/drivers/ide/ide-probe.c\n" - "> > @@ -856,7 +856,7 @@ static void ide_port_tune_devices(ide_hwif_t *hwif)\n" - "> > \t\tide_drive_t *drive = &hwif->drives[unit];\n" - "> > \n" - "> > \t\tif ((hwif->host_flags & IDE_HFLAG_NO_IO_32BIT) ||\n" - "> > -\t\t drive->id[ATA_ID_DWORD_IO])\n" - "> > +\t\t !ata_id_has_dword_io(drive->id))\n" - "> > \t\t\tdrive->dev_flags |= IDE_DFLAG_NO_IO_32BIT;\n" - "> > \t\telse\n" - "> > \t\t\tdrive->dev_flags &= ~IDE_DFLAG_NO_IO_32BIT;\n" - "> \n" - "> Since it seems that libata developers need more time to fully analyze\n" - "> issues with ata_id_has_dword_io() and I don't want to delay this fix\n" - "> because if it could you please modify the patch according to Sergei's\n" - "> suggestion of removing id[ATA_ID_DWORD_IO] check altogether?\n" - "> \n" - "> [ It is a safe thing to do since the old code has been enabling 32-bit\n" - "> I/O _unless_ the ATA-1 dword I/O bit for VU compatibility was set... ]\n" - "\n" + "On Friday 19 December 2008, Bartlomiej Zolnierkiewicz wrote:> On Thursday 18 December 2008, Mario Schwalbe wrote:> > Resubmitted on request.> > > > According the documentation, id[ATA_ID_DWORD_IO] is non-zero if> > the drive supports dword IO, while the code disables support by> > setting IDE_DFLAG_NO_IO_32BIT. In addition, this word has been> > reused by the ATA8 specification. This patch fixes both cases.> > > > Signed-off-by: Mario Schwalbe <schwalbe@inf.tu-dresden.de>> > ---> > drivers/ide/ide-probe.c | 2 +-> > 1 files changed, 1 insertions(+), 1 deletions(-)> > > > diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c> > index c55bdbd..859b0e5 100644> > --- a/drivers/ide/ide-probe.c> > +++ b/drivers/ide/ide-probe.c> > @@ -856,7 +856,7 @@ static void ide_port_tune_devices(ide_hwif_t *hwif)> > \t\tide_drive_t *drive = &hwif->drives[unit];> > > > \t\tif ((hwif->host_flags & IDE_HFLAG_NO_IO_32BIT) ||> > -\t\t drive->id[ATA_ID_DWORD_IO])> > +\t\t !ata_id_has_dword_io(drive->id))> > \t\t\tdrive->dev_flags |= IDE_DFLAG_NO_IO_32BIT;> > \t\telse> > \t\t\tdrive->dev_flags &= ~IDE_DFLAG_NO_IO_32BIT;> > Since it seems that libata developers need more time to fully analyze> issues with ata_id_has_dword_io() and I don't want to delay this fix> because if it could you please modify the patch according to Sergei's> suggestion of removing id[ATA_ID_DWORD_IO] check altogether?> > [ It is a safe thing to do since the old code has been enabling 32-bit> I/O _unless_ the ATA-1 dword I/O bit for VU compatibility was set... ]\n" "I merged the patch and did the modification while at it:\n" - "\n" - "From: Mario Schwalbe <schwalbe@inf.tu-dresden.de>\n" - "Subject: [PATCH] ide: Fix drive's DWORD-IO handling\n" - "\n" - "According the documentation, id[ATA_ID_DWORD_IO] is non-zero if\n" - "the drive supports dword IO, while the code disables support by\n" - "setting IDE_DFLAG_NO_IO_32BIT. In addition, this word has been\n" - "reused by the ATA8 specification. This patch fixes both cases.\n" - "\n" - "Signed-off-by: Mario Schwalbe <schwalbe@inf.tu-dresden.de>\n" - "Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>\n" - "[bart: remove id[ATA_ID_DWORD_IO] check altogether per Sergei's suggestion]\n" - "Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>\n" - "---\n" - " drivers/ide/ide-probe.c | 3 +--\n" - " 1 file changed, 1 insertion(+), 2 deletions(-)\n" - "\n" - "Index: b/drivers/ide/ide-probe.c\n" - "===================================================================\n" - "--- a/drivers/ide/ide-probe.c\n" - "+++ b/drivers/ide/ide-probe.c\n" - "@@ -849,8 +849,7 @@ static void ide_port_tune_devices(ide_hw\n" - " \t}\n" - " \n" - " \tide_port_for_each_dev(i, drive, hwif) {\n" - "-\t\tif ((hwif->host_flags & IDE_HFLAG_NO_IO_32BIT) ||\n" - "-\t\t drive->id[ATA_ID_DWORD_IO])\n" - "+\t\tif (hwif->host_flags & IDE_HFLAG_NO_IO_32BIT)\n" - " \t\t\tdrive->dev_flags |= IDE_DFLAG_NO_IO_32BIT;\n" - " \t\telse\n" - " \t\t\tdrive->dev_flags &= ~IDE_DFLAG_NO_IO_32BIT;\n" - "\0" + "From: Mario Schwalbe <schwalbe@inf.tu-dresden.de>Subject: [PATCH] ide: Fix drive's DWORD-IO handling\n" + "According the documentation, id[ATA_ID_DWORD_IO] is non-zero ifthe drive supports dword IO, while the code disables support bysetting IDE_DFLAG_NO_IO_32BIT. In addition, this word has beenreused by the ATA8 specification. This patch fixes both cases.\n" + "Signed-off-by: Mario Schwalbe <schwalbe@inf.tu-dresden.de>Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>[bart: remove id[ATA_ID_DWORD_IO] check altogether per Sergei's suggestion]Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>--- drivers/ide/ide-probe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)\n" + "Index: b/drivers/ide/ide-probe.c===================================================================--- a/drivers/ide/ide-probe.c+++ b/drivers/ide/ide-probe.c@@ -849,8 +849,7 @@ static void ide_port_tune_devices(ide_hw \t} \tide_port_for_each_dev(i, drive, hwif) {-\t\tif ((hwif->host_flags & IDE_HFLAG_NO_IO_32BIT) ||-\t\t drive->id[ATA_ID_DWORD_IO])+\t\tif (hwif->host_flags & IDE_HFLAG_NO_IO_32BIT) \t\t\tdrive->dev_flags |= IDE_DFLAG_NO_IO_32BIT; \t\telse \t\t\tdrive->dev_flags &= ~IDE_DFLAG_NO_IO_32BIT;\0\n" + "\303\277\303\264\303\250\302\272{.n\303\207+\302\211\302\267\302\237\302\256\302\211\302\255\302\206+%\302\212\303\213\303\277\302\261\303\251\303\235\302\266\027\302\245\302\212w\303\277\302\272{.n\303\207+\302\211\302\267\302\245\302\212{\302\261\303\276G\302\253\302\235\303\251\303\277\302\212{ay\302\272\035\303\212\302\207\303\232\302\231\303\253,j\a\302\255\302\242f\302\243\302\242\302\267h\302\232\302\217\303\257\302\201\303\252\303\277\302\221\303\252\303\247z_\303\250\302\256\003(\302\255\303\251\302\232\302\216\302\212\303\235\302\242j\"\302\235\303\272\032\302\266\033m\302\247\303\277\303\277\305\270\a\302\253\303\276G\302\253\302\235\303\251\303\277\302\242\305\276?\302\231\305\241\303\250\302\255\303\232&\302\243\303\270\302\247~\302\217\303\241\302\266iO\302\225\303\246\302\254z\302\267\302\232v\303\230^\024\004\032\302\266\033m\302\247\303\277\303\277\303\203\f\303\277\302\266\303\254\303\277\302\242\305\276?\302\226I\302\245" -cdc0f699927aabef4ead074150730c6cd7cd74b2b88f10b8292933b2a0bfb3bc +7d0e1bb4f099fbf89594cc50279edac10fac5304b7f1d6cf0516f5b8805f0772
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.