All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: John Stanley <jpsinthemix@verizon.net>, xfs@oss.sgi.com
Subject: Re: [PATCH, RFC] directory offset overflows in 2.6.28
Date: Wed, 31 Dec 2008 10:34:15 +1100	[thread overview]
Message-ID: <20081230233415.GA10725@disturbed> (raw)
In-Reply-To: <20081230155726.GA30568@infradead.org>

On Tue, Dec 30, 2008 at 10:57:26AM -0500, Christoph Hellwig wrote:
> On Tue, Dec 30, 2008 at 11:11:17AM +1100, Dave Chinner wrote:
> > On Mon, Dec 29, 2008 at 05:07:45PM -0500, Christoph Hellwig wrote:
> > > The patch below is a dumb version of just putting back the masking,
> > > to make sure we have the same behavior as in 2.6.27 and earlier.
> > > I think we should at least hide it in a macro that is well-commented,
> > > but I suspect we also need to make sure that we never ever get bigger
> > > offsets in directories in some way.
> > 
> > I think we need that macro sooner rather than later ;)
> 
> > In this case, you can do the masking at the time cook is
> > assigned. I haven't checked, but I suspect the rest will be the
> > same. That will make the patch less invasive and with a macro
> > somewhat cleaner...
> 
> That way we could replace two assignment by one one time each
> in xfs_dir2_leaf.c and xfs_dir2_block.c.
> 
> I started working on the macro, but it seems even more hacky.
> 
> When looking at the big picture we have two problems:
> 
>  - the end of directory marker which always seems to be always too
>    large for 32bit values for 32 bit indices
>  - directories that actually are too large to be represented using
>    32 bit signed offsets.  I guess we just can't support those
>    for apps using the 32bit readdir interface and the EOVERFLOW
>    is valid for those.  The current approach as in < 2.6.28 and
>    with this patch breaks that second case in subtile ways.
> 
> So, I'd just push the first hacky opencoded patch into 2.6.29 and
> -stable now to revert to the old behaviour with all it's faults, and
> in the meantime I'll look into a proper way finding a better end of
> directory indicator.  That should also help Russell's BSD concerns.

Ok, sounds like a plan.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2008-12-30 23:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-29 22:07 [PATCH, RFC] directory offset overflows in 2.6.28 Christoph Hellwig
2008-12-30  0:11 ` Dave Chinner
2008-12-30  4:16   ` Russell Cattelan
2008-12-30 15:57   ` Christoph Hellwig
2008-12-30 23:34     ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081230233415.GA10725@disturbed \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jpsinthemix@verizon.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.