Re: [meta-oe][PATCH v2 2/2] qt4: remove bbappend content

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Wednesday 10 April 2013 18:16:28 Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Op 10-04-13 17:57, Paul Eggleton schreef:
> > These changes to Qt's configuration need to be applied in distro layers,
> > not in meta-oe.
> > 
> > (We have to preserve the PRINC value to avoid PR going backwards.)
> > 
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> ---
> > meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend |    5 -----
> > meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend |    5 ----- 2 files
> > changed, 10 deletions(-)
> > 
> > diff --git a/meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend
> > b/meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend index
> > 27cac11..d9f1c29 100644 ---
> > a/meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend +++
> > b/meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend @@ -1,6 +1 @@
> > -DEPENDS += "mysql5 postgresql sqlite" -QT_SQL_DRIVER_FLAGS =
> > "-no-sql-ibase -plugin-sql-mysql -no-sql-odbc -plugin-sql-psql
> > -plugin-sql-sqlite2 -plugin-sql-sqlite" -QT_CONFIG_FLAGS +=
> > "-I${STAGING_INCDIR}/mysql \ -
> > -I${STAGING_INCDIR}/postgresql" - PRINC := "${@int(PRINC) + 1}" diff
> > --git a/meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend
> > b/meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend index
> > 27cac11..d9f1c29 100644 ---
> > a/meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend +++
> > b/meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend @@ -1,6 +1 @@
> > -DEPENDS += "mysql5 postgresql sqlite" -QT_SQL_DRIVER_FLAGS =
> > "-no-sql-ibase -plugin-sql-mysql -no-sql-odbc -plugin-sql-psql
> > -plugin-sql-sqlite2 -plugin-sql-sqlite" -QT_CONFIG_FLAGS +=
> > "-I${STAGING_INCDIR}/mysql \ -
> > -I${STAGING_INCDIR}/postgresql" - PRINC := "${@int(PRINC) + 1}"
> 
> So with the reason given "I don't want to rebuilt QT when adding meta-oe" to
> remove this, this doesn't actually accomplish that. You are adding an extra
> rebuild with this.

That's the reason I don't want the bbappend to exist at all. In the absence of 
the ability to have that for now, let's at least not have the configuration 
changed and not have postgres and mysql built just by adding meta-oe.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre