From: "Udo A. Steinberg" <udo@hypervisor.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mchehab@infradead.org
Cc: v4l-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com
Subject: [PATCH] Missing v4l2_prio_close in radio_release
Date: Fri, 2 Jan 2009 06:41:00 +0100 [thread overview]
Message-ID: <20090102064100.2e27464e@laptop.hypervisor.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
The radio_release function of the BTTV driver is missing a call to
v4l2_prio_close. As a result, after the radio device has been opened at
least once (e.g., by HAL during bootup), v4l2_priority will never drop below
V4L2_PRIORITY_INTERACTIVE again. With the following patch against 2.6.28,
applications that run with V4L2_PRIORITY_BACKGROUND are able to open devices
again. Previous Linux versions are affected as well.
Signed-off-by: Udo Steinberg <udo@hypervisor.org>
--- linux-2.6.28/drivers/media/video/bt8xx/bttv-driver.c 2008-10-10 00:13:53.000000000 +0200
+++ linux-2.6.28/drivers/media/video/bt8xx/bttv-driver.new 2009-01-02 06:23:38.000000000 +0100
@@ -3473,6 +3474,7 @@
struct bttv *btv = fh->btv;
struct rds_command cmd;
+ v4l2_prio_close(&btv->prio,&fh->prio);
file->private_data = NULL;
kfree(fh);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
reply other threads:[~2009-01-02 6:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102064100.2e27464e@laptop.hypervisor.org \
--to=udo@hypervisor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.