From: "J. Bruce Fields" <bfields@fieldses.org>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
jmorris@namei.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] CRED: Fix regression in cap_capable() as shown up by sys_faccessat() [ver #2]
Date: Fri, 2 Jan 2009 11:45:05 -0500 [thread overview]
Message-ID: <20090102164505.GA10465@fieldses.org> (raw)
In-Reply-To: <32481.1230897578@redhat.com>
On Fri, Jan 02, 2009 at 11:59:38AM +0000, David Howells wrote:
> J. Bruce Fields <bfields@fieldses.org> wrote:
>
> > No. I started bisecting, and it does appear to be a regression from the
> > cred patches, but at some point in the middle there it hangs on boot (a
> > softlockup report blames a spinlock in set_groups).
>
> Do you remember which patch you were at?
It appears that:
- 1cdcbec1a3372c0c49c59d292e708fd07b509f18 "CRED: Neuter
sys_capset()" is good
- 98870ab0a5a3f1822aee681d2997017e1c87d026 "CRED: Documentation"
is bad
- f1752eec6145c97163dbce62d17cf5d928e28a27 and
d84f4f992cbd76e8f39c488cf0c5d123843923b1 produce the soft
lookup in set_groups()
... and I haven't figured out what's in between. And the test failure
is nfsd_lookup() returning OK on a directory when it should return
nfserr_perm. I assume that's the result of inode_permission(directory
inode, MAY_EXEC) returning 0 when it shouldn't, but I haven't confirmed
that.
--b.
next prev parent reply other threads:[~2009-01-02 16:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 13:42 access(2) regressions in current mainline Christoph Hellwig
2008-12-30 17:06 ` David Howells
2008-12-30 17:09 ` Christoph Hellwig
2008-12-30 17:20 ` David Howells
2008-12-30 17:29 ` Christoph Hellwig
2008-12-30 17:54 ` David Howells
2008-12-31 2:05 ` Dave Chinner
2008-12-31 3:28 ` [PATCH] CRED: Fix regression in cap_capable() as shown up by sys_faccessat() David Howells
2008-12-31 15:15 ` [PATCH] CRED: Fix regression in cap_capable() as shown up by sys_faccessat() [ver #2] David Howells
2008-12-31 23:24 ` James Morris
2009-01-01 23:53 ` J. Bruce Fields
2009-01-02 1:19 ` David Howells
2009-01-02 5:19 ` J. Bruce Fields
2009-01-02 11:59 ` David Howells
2009-01-02 16:45 ` J. Bruce Fields [this message]
2009-01-03 18:49 ` J. Bruce Fields
2009-01-03 23:03 ` David Howells
2009-01-04 2:03 ` J. Bruce Fields
2009-01-05 13:11 ` David Howells
2009-01-05 15:57 ` David Howells
2009-01-05 16:48 ` David Howells
2009-01-05 17:19 ` [PATCH] CRED: Fix NFSD regression David Howells
2009-01-05 22:22 ` James Morris
2009-01-06 19:41 ` J. Bruce Fields
2009-01-06 19:56 ` David Howells
2009-01-06 20:08 ` J. Bruce Fields
2009-01-02 16:48 ` [PATCH] CRED: Fix regression in cap_capable() as shown up by sys_faccessat() [ver #2] J. Bruce Fields
2009-01-02 19:18 ` David Howells
2009-01-05 2:07 ` James Morris
2009-01-05 3:18 ` Serge E. Hallyn
2009-01-05 3:37 ` Serge E. Hallyn
2009-01-05 12:43 ` David Howells
2009-01-05 19:07 ` Serge E. Hallyn
2009-01-05 21:12 ` David Howells
2009-01-06 16:47 ` Serge E. Hallyn
2009-01-06 20:39 ` David Howells
2009-01-06 20:56 ` Serge E. Hallyn
2009-01-06 22:27 ` [PATCH] CRED: Fix regression in cap_capable() as shown up by sys_faccessat() [ver #3] David Howells
2009-01-06 22:53 ` James Morris
2009-01-06 23:57 ` J. Bruce Fields
2009-01-07 0:09 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102164505.GA10465@fieldses.org \
--to=bfields@fieldses.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.