From: Arnd Bergmann <arnd@arndb.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Arjan van de Ven <arjan@infradead.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] headers_check.pl: disallow extern's
Date: Sat, 3 Jan 2009 02:40:28 +0100 [thread overview]
Message-ID: <200901030240.28759.arnd@arndb.de> (raw)
In-Reply-To: <200901022020.44200.vapier@gentoo.org>
On Saturday 03 January 2009, Mike Frysinger wrote:
> On Friday 02 January 2009 19:09:57 Arnd Bergmann wrote:
> > On Saturday 03 January 2009, Arjan van de Ven wrote:
> > > in addition... what business does the kernel have to provide function
> > > prototypes to userspace, other than the system call prototypes?
> >
> > This is the point I raised in my initial comment: we should warn about
> > all of them if possible. Note that the syscalls.h file is not even
> > exported. I can't think of a single case where a function protoype
> > should be exported from the kernel to user space.
>
> right, and unless people someone can come up with some magic perl code to
> detect function prototypes, i suggest we start adding extern keywords ...
In the presence of /usr/bin/ctags-exuberant, we can use that to find all of
these. If it doesn't exist, just don't check or warn about the fact that
we might be missing checks.
Arnd <><
next prev parent reply other threads:[~2009-01-03 1:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 7:43 [PATCH] headers_check.pl: disallow extern's Mike Frysinger
2008-12-27 18:43 ` Sam Ravnborg
2008-12-27 18:54 ` Sam Ravnborg
2008-12-27 19:21 ` Mike Frysinger
2008-12-29 10:15 ` Mike Frysinger
2008-12-29 12:00 ` Sam Ravnborg
2008-12-27 19:23 ` Mike Frysinger
2008-12-31 16:58 ` Arnd Bergmann
2008-12-31 22:32 ` Mike Frysinger
2009-01-02 23:59 ` Arnd Bergmann
2009-01-03 0:05 ` Arjan van de Ven
2009-01-03 0:09 ` Arnd Bergmann
2009-01-03 1:20 ` Mike Frysinger
2009-01-03 1:40 ` Arnd Bergmann [this message]
2009-01-03 1:51 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901030240.28759.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.