From: Bill Fink <billfink@mindspring.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH 2/2] ieee1934: dv1394 interrupt enabling/disabling broken on big-endian
Date: Sat, 3 Jan 2009 21:18:43 -0500 [thread overview]
Message-ID: <20090103211843.d36d252f.billfink@mindspring.com> (raw)
In-Reply-To: <495F976C.8030105@s5r6.in-berlin.de>
On Sat, 03 Jan 2009, Stefan Richter wrote:
> Bill Fink wrote on 2008-12-26:
> > Good news. I finally got a chance to test the patch on my kernel,
> > and live DV viewing using xine still worked fine.
>
> Thanks a lot. If you don't mind, I'll add "Tested-by: Bill Fink
> <billfink@mindspring.com>" to the changelog when I enqueue this for
> Linus, and add a note that it actually worked for you before as well as
> after this patch.
That's fine. Although I admit to being mystified how it works both
before and after the patch, since the cpu_to_le32() calls that were
added should result in byte swapping on PPC that wasn't being done
before. I guess that either the code paths involved aren't actually
being triggered by my xine DV viewing, or there's some fortuitous
palindromic setting of bits.
-Bill
next prev parent reply other threads:[~2009-01-04 2:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 23:21 [PATCH 2/2] ieee1934: dv1394 interrupt enabling/disabling broken on big-endian Harvey Harrison
2008-12-14 0:41 ` Stefan Richter
2008-12-14 1:41 ` Bill Fink
2008-12-14 2:02 ` Stefan Richter
2008-12-23 22:23 ` Bill Fink
2008-12-26 3:02 ` Bill Fink
2009-01-03 16:50 ` Stefan Richter
2009-01-04 2:18 ` Bill Fink [this message]
2009-01-04 21:03 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090103211843.d36d252f.billfink@mindspring.com \
--to=billfink@mindspring.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.