From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@infradead.org>
Cc: x86 maintainers <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: setup.c fix style problems
Date: Sun, 4 Jan 2009 18:21:14 +0100 [thread overview]
Message-ID: <20090104172114.GA32425@elte.hu> (raw)
In-Reply-To: <1231066898.27852.29.camel@jaswinder.satnam>
* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:
> Impact: cleanup, fix style problems, more readable
>
> Fixes style problems:
> WARNING: Use #include <linux/smp.h> instead of <asm/smp.h>
> WARNING: Use #include <linux/percpu.h> instead of <asm/percpu.h>
> WARNING: Use #include <linux/topology.h> instead of <asm/topology.h>
> WARNING: externs should be avoided in .c files
> ERROR: code indent should use tabs where possible
>
> total: 2 errors, 4 warnings
doesnt build on some configs:
arch/x86/kernel/setup.c:943: error: implicit declaration of function 'prefill_possible_map'
the x86-local declarations in smp.h should probably be moved into a
separate smp_x86.h file - to avoid such trouble.
Ingo
next prev parent reply other threads:[~2009-01-04 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 11:01 [PATCH -tip] x86: setup.c fix style problems Jaswinder Singh Rajput
2009-01-04 17:21 ` Ingo Molnar [this message]
2009-01-04 17:27 ` Jaswinder Singh Rajput
2009-01-04 17:57 ` Jaswinder Singh Rajput
2009-01-04 20:34 ` Ingo Molnar
2009-01-05 5:04 ` Jaswinder Singh Rajput
2009-01-05 13:15 ` Ingo Molnar
2009-01-05 13:22 ` Jaswinder Singh Rajput
2009-01-05 13:50 ` Ingo Molnar
2009-01-05 14:03 ` Jaswinder Singh Rajput
2009-01-06 10:07 ` Jaswinder Singh Rajput
2009-01-06 12:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090104172114.GA32425@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.