From: Evgeniy Dushistov <dushistov@mail.ru>
To: Duane Griffin <duaneg@dghda.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ufs: validate maximum fast symlink size from superblock
Date: Sun, 4 Jan 2009 22:15:59 +0300 [thread overview]
Message-ID: <20090104191558.GA23805@rain> (raw)
In-Reply-To: <1230742208-23972-1-git-send-email-duaneg@dghda.com>
On Wed, Dec 31, 2008 at 04:50:05PM +0000, Duane Griffin wrote:
> The maximum fast symlink size is set in the superblock of certain types
> of UFS filesystem. Before using it we need to check that it isn't longer
> than the available space we have in the inode.
>
> Signed-off-by: Duane Griffin <duaneg@dghda.com>
> ---
> fs/ufs/super.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ufs/super.c b/fs/ufs/super.c
> + printk(KERN_WARNING "ufs_read_super: excessive maximum fast "
> + "symlink size (%u)\n", uspi->s_maxsymlinklen);
> + uspi->s_maxsymlinklen = maxsymlen;
> + }
> +
Better and logically to use ufs_warning here, because of it show device id,
in case person has serveral ufs formated partitions and mount happened
during system boot time.
--
/Evgeniy
prev parent reply other threads:[~2009-01-04 19:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 16:50 [PATCH 1/4] ufs: validate maximum fast symlink size from superblock Duane Griffin
2008-12-31 16:50 ` [PATCH 2/4] ufs: don't truncate longer ufs2 fast symlinks Duane Griffin
2008-12-31 16:50 ` [PATCH 3/4] ufs: ensure fast symlinks are NUL-terminated Duane Griffin
2008-12-31 16:50 ` [PATCH 4/4] ufs: copy symlink data into the correct union member Duane Griffin
2009-01-01 2:36 ` Al Viro
2009-01-02 14:17 ` Duane Griffin
2009-01-01 2:32 ` [PATCH 2/4] ufs: don't truncate longer ufs2 fast symlinks Al Viro
2009-01-02 14:09 ` Duane Griffin
2009-01-04 19:15 ` Evgeniy Dushistov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090104191558.GA23805@rain \
--to=dushistov@mail.ru \
--cc=duaneg@dghda.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.