From: Frederic Weisbecker <fweisbec@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [PATCH] tracing/kmemtrace: normalize the raw tracer event to the unified tracing API
Date: Tue, 6 Jan 2009 00:50:48 +0100 [thread overview]
Message-ID: <20090105235047.GA6531@nowhere> (raw)
In-Reply-To: <alpine.DEB.1.10.0901051146470.27085@gandalf.stny.rr.com>
On Mon, Jan 05, 2009 at 11:48:56AM -0500, Steven Rostedt wrote:
>
> On Tue, 30 Dec 2008, Ingo Molnar wrote:
>
> >
> > * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> >
> > > kernel/trace/trace_kmemtrace.c | 345 ++++++++++++++++++++++++++++++++++++++++
> >
> > btw., i renamed this to kernel/trace/kmemtrace.c. Mentioning 'trace' twice
> > is enough already ;-)
>
> Should we rename all the kernel/trace/trace_(.*)\.c to kernel/trace/\1.c ?
>
> Although I do like the trace in the function name, because it groups them
> nicely together, and keeps ftrace.c and ring_buffer.c stand out from the
> rest.
>
> -- Steve
>
Or why not a subdirectory called "tracers" inside kernel/trace to store
the tracers files. This way, the core of tracing (ftrace.c/ring_buffer.c/trace_output.c/
/trace.c/trace_stat.c) can be found easily against the rest. Moreover, there is a risk that
the number of tracers will tend to increase by the time.
prev parent reply other threads:[~2009-01-05 23:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 21:42 [PATCH] tracing/kmemtrace: normalize the raw tracer event to the unified tracing API Frederic Weisbecker, Frederic Weisbecker
2008-12-29 21:46 ` Frederic Weisbecker
2008-12-29 22:09 ` Frederic Weisbecker
2008-12-29 22:13 ` Frederic Weisbecker
2008-12-30 7:49 ` Pekka Enberg
2008-12-30 8:01 ` Eduard - Gabriel Munteanu
2008-12-30 8:16 ` Ingo Molnar
2008-12-30 8:41 ` Eduard - Gabriel Munteanu
2008-12-30 8:47 ` Ingo Molnar
2008-12-30 9:01 ` Pekka Enberg
2008-12-30 9:11 ` Ingo Molnar
2008-12-30 14:16 ` Frederic Weisbecker
2008-12-30 15:37 ` Ingo Molnar
2008-12-30 21:09 ` Frederic Weisbecker
2008-12-30 14:32 ` Frederic Weisbecker
2008-12-30 8:00 ` Ingo Molnar
2008-12-30 7:34 ` Ingo Molnar
2008-12-30 7:45 ` Ingo Molnar
2009-01-05 16:48 ` Steven Rostedt
2009-01-05 23:50 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105235047.GA6531@nowhere \
--to=fweisbec@gmail.com \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.