From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n068hH2g032338 for ; Tue, 6 Jan 2009 02:43:17 -0600 Received: from mx2.suse.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 207D264B72 for ; Tue, 6 Jan 2009 00:43:16 -0800 (PST) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by cuda.sgi.com with ESMTP id GAnE9kwK3ytWqW3A for ; Tue, 06 Jan 2009 00:43:16 -0800 (PST) Date: Tue, 6 Jan 2009 09:43:12 +0100 From: Nick Piggin Subject: Re: [patch] mm: fix lockless pagecache reordering bug (was Re: BUG: soft lockup - is this XFS problem?) Message-ID: <20090106084312.GC16738@wotan.suse.de> References: <49623384.2070801@aon.at> <20090105164135.GC32675@wotan.suse.de> <20090105180008.GE32675@wotan.suse.de> <20090105201258.GN6959@linux.vnet.ibm.com> <20090105215727.GQ6959@linux.vnet.ibm.com> <20090106020550.GA819@wotan.suse.de> <49631877.3090803@aon.at> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <49631877.3090803@aon.at> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Peter Klotz Cc: linux-kernel@vger.kernel.org, Roman Kononov , xfs@oss.sgi.com, Christoph Hellwig , Linux Memory Management List , Andrew Morton , "Paul E. McKenney" , Linus Torvalds , stable@kernel.org On Tue, Jan 06, 2009 at 09:38:15AM +0100, Peter Klotz wrote: > >Index: linux-2.6/include/linux/radix-tree.h > >=================================================================== > >--- linux-2.6.orig/include/linux/radix-tree.h > >+++ linux-2.6/include/linux/radix-tree.h > >@@ -136,7 +136,7 @@ do { \ > > */ > > static inline void *radix_tree_deref_slot(void **pslot) > > { > >- void *ret = *pslot; > >+ void *ret = rcu_dereference(*pslot); > > if (unlikely(radix_tree_is_indirect_ptr(ret))) > > ret = RADIX_TREE_RETRY; > > return ret; > > > > > > The patch above fixes my problem. I did two complete test runs that > normally fail rather quickly. OK, thanks for reporting and testing. I think this patch is a candidate for -stable too. Thanks, Nick _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752639AbZAFInZ (ORCPT ); Tue, 6 Jan 2009 03:43:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751434AbZAFInR (ORCPT ); Tue, 6 Jan 2009 03:43:17 -0500 Received: from ns2.suse.de ([195.135.220.15]:34387 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbZAFInQ (ORCPT ); Tue, 6 Jan 2009 03:43:16 -0500 Date: Tue, 6 Jan 2009 09:43:12 +0100 From: Nick Piggin To: Peter Klotz Cc: "Paul E. McKenney" , Linus Torvalds , stable@kernel.org, Linux Memory Management List , Christoph Hellwig , Roman Kononov , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Andrew Morton Subject: Re: [patch] mm: fix lockless pagecache reordering bug (was Re: BUG: soft lockup - is this XFS problem?) Message-ID: <20090106084312.GC16738@wotan.suse.de> References: <49623384.2070801@aon.at> <20090105164135.GC32675@wotan.suse.de> <20090105180008.GE32675@wotan.suse.de> <20090105201258.GN6959@linux.vnet.ibm.com> <20090105215727.GQ6959@linux.vnet.ibm.com> <20090106020550.GA819@wotan.suse.de> <49631877.3090803@aon.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49631877.3090803@aon.at> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 06, 2009 at 09:38:15AM +0100, Peter Klotz wrote: > >Index: linux-2.6/include/linux/radix-tree.h > >=================================================================== > >--- linux-2.6.orig/include/linux/radix-tree.h > >+++ linux-2.6/include/linux/radix-tree.h > >@@ -136,7 +136,7 @@ do { \ > > */ > > static inline void *radix_tree_deref_slot(void **pslot) > > { > >- void *ret = *pslot; > >+ void *ret = rcu_dereference(*pslot); > > if (unlikely(radix_tree_is_indirect_ptr(ret))) > > ret = RADIX_TREE_RETRY; > > return ret; > > > > > > The patch above fixes my problem. I did two complete test runs that > normally fail rather quickly. OK, thanks for reporting and testing. I think this patch is a candidate for -stable too. Thanks, Nick From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 81B0D6B00DD for ; Tue, 6 Jan 2009 03:43:18 -0500 (EST) Date: Tue, 6 Jan 2009 09:43:12 +0100 From: Nick Piggin Subject: Re: [patch] mm: fix lockless pagecache reordering bug (was Re: BUG: soft lockup - is this XFS problem?) Message-ID: <20090106084312.GC16738@wotan.suse.de> References: <49623384.2070801@aon.at> <20090105164135.GC32675@wotan.suse.de> <20090105180008.GE32675@wotan.suse.de> <20090105201258.GN6959@linux.vnet.ibm.com> <20090105215727.GQ6959@linux.vnet.ibm.com> <20090106020550.GA819@wotan.suse.de> <49631877.3090803@aon.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49631877.3090803@aon.at> Sender: owner-linux-mm@kvack.org To: Peter Klotz Cc: "Paul E. McKenney" , Linus Torvalds , stable@kernel.org, Linux Memory Management List , Christoph Hellwig , Roman Kononov , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Andrew Morton List-ID: On Tue, Jan 06, 2009 at 09:38:15AM +0100, Peter Klotz wrote: > >Index: linux-2.6/include/linux/radix-tree.h > >=================================================================== > >--- linux-2.6.orig/include/linux/radix-tree.h > >+++ linux-2.6/include/linux/radix-tree.h > >@@ -136,7 +136,7 @@ do { \ > > */ > > static inline void *radix_tree_deref_slot(void **pslot) > > { > >- void *ret = *pslot; > >+ void *ret = rcu_dereference(*pslot); > > if (unlikely(radix_tree_is_indirect_ptr(ret))) > > ret = RADIX_TREE_RETRY; > > return ret; > > > > > > The patch above fixes my problem. I did two complete test runs that > normally fail rather quickly. OK, thanks for reporting and testing. I think this patch is a candidate for -stable too. Thanks, Nick -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org