diff for duplicates of <200901061152.51782.rusty@rustcorp.com.au> diff --git a/a/1.txt b/N1/1.txt index 9076da0..f348e58 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,11 +6,11 @@ On Tuesday 06 January 2009 07:00:25 Steven Rostedt wrote: ... > /* Suck in entire file: we'll want most of it. */ > /* vmalloc barfs on "unusual" numbers. Check here */ -> - if (len > 64 * 1024 * 1024 || (hdr = vmalloc(len)) = NULL) +> - if (len > 64 * 1024 * 1024 || (hdr = vmalloc(len)) == NULL) > + if (len > 64 * 1024 * 1024) > + return ERR_PTR(-ENOMEM); > + hdr = vmalloc(len); -> + if (hdr = NULL) +> + if (hdr == NULL) > return ERR_PTR(-ENOMEM); > if (copy_from_user(hdr, umod, len) != 0) { > err = -EFAULT; diff --git a/a/content_digest b/N1/content_digest index d293cb7..1e3bb92 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0alpine.DEB.1.10.0901051523370.25066@gandalf.stny.rr.com\0" "From\0Rusty Russell <rusty@rustcorp.com.au>\0" "Subject\0Re: [PATCH] module: clean up initialization of variable\0" - "Date\0Tue, 06 Jan 2009 01:34:50 +0000\0" + "Date\0Tue, 6 Jan 2009 11:52:50 +1030\0" "To\0Steven Rostedt <rostedt@goodmis.org>\0" "Cc\0Sam Ravnborg <sam@ravnborg.org>" LKML <linux-kernel@vger.kernel.org> @@ -22,11 +22,11 @@ "...\n" "> \t/* Suck in entire file: we'll want most of it. */\n" "> \t/* vmalloc barfs on \"unusual\" numbers. Check here */\n" - "> -\tif (len > 64 * 1024 * 1024 || (hdr = vmalloc(len)) = NULL)\n" + "> -\tif (len > 64 * 1024 * 1024 || (hdr = vmalloc(len)) == NULL)\n" "> +\tif (len > 64 * 1024 * 1024)\n" "> +\t\treturn ERR_PTR(-ENOMEM);\n" "> +\thdr = vmalloc(len);\n" - "> +\tif (hdr = NULL)\n" + "> +\tif (hdr == NULL)\n" "> \t\treturn ERR_PTR(-ENOMEM);\n" "> \tif (copy_from_user(hdr, umod, len) != 0) {\n" "> \t\terr = -EFAULT;\n" @@ -42,4 +42,4 @@ "Thanks,\n" Rusty. -6f8a04d18bf2ca98498ee65ff12508b2c6c084694d0089fc0323ecb392342627 +5070fd437ff3dfbead472ab043291743e2c194000d8ee98bc129b5fd13bc3e6f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.