From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, Dmitri Monakhov <dmonakhov@openvz.org>
Subject: Re: 2.6.29 -mm merge plans
Date: Tue, 6 Jan 2009 15:08:55 -0800 [thread overview]
Message-ID: <20090106150855.5f362a2d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090106225744.GA10553@infradead.org>
(cc added)
On Tue, 6 Jan 2009 17:57:44 -0500
Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Jan 05, 2009 at 12:43:00AM -0800, Andrew Morton wrote:
> > fs-truncate-blocks-outside-i_size-after-o_direct-write-error.patch
> > fs-truncate-blocks-outside-i_size-after-o_direct-write-error-fix.patch
>
> Btw, this code is still not quite right. We really need to call
> ->setattr instead of vmtruncate here. Complex filesystem need
> transaction to properly free blocks, and those transactions are in
> ->setattr not inside vmtruncate where ->truncate doesn't even have
> a chance to get the handle to the transaction passed.
>
> As these patches don't make it worse this is not a NACK, but more of
> a heads up.
Sure. Maybe add a FIXME comment for now?
next prev parent reply other threads:[~2009-01-06 23:09 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 8:43 2.6.29 -mm merge plans Andrew Morton
2009-01-05 9:00 ` KOSAKI Motohiro
2009-01-05 9:07 ` Andrew Morton
2009-01-05 22:31 ` Ying Han
2009-01-05 22:34 ` Valdis.Kletnieks
2009-01-08 4:18 ` Ying Han
2009-01-08 4:41 ` KOSAKI Motohiro
2009-01-08 7:57 ` Ying Han
2009-01-08 8:31 ` KOSAKI Motohiro
2009-01-11 4:18 ` Valdis.Kletnieks
2009-01-12 4:18 ` Ying Han
2009-01-06 5:27 ` Valdis.Kletnieks
2009-01-06 5:41 ` Nick Piggin
2009-01-05 9:02 ` Sam Ravnborg
2009-01-05 9:12 ` Andrew Morton
2009-01-05 9:17 ` David Miller
2009-01-05 9:21 ` Ingo Molnar
2009-01-05 9:39 ` Sam Ravnborg
2009-01-05 10:10 ` Ingo Molnar
2009-01-05 10:36 ` David Miller
2009-01-05 12:32 ` Ingo Molnar
2009-01-05 10:11 ` Ingo Molnar
2009-01-05 10:37 ` David Miller
2009-01-05 9:40 ` Ryusuke Konishi
2009-01-06 13:30 ` Pekka Enberg
2009-01-07 3:26 ` Ryusuke Konishi
2009-01-07 7:58 ` Pekka Enberg
2009-01-07 14:17 ` Chris Mason
2009-01-05 11:34 ` Al Viro
2009-01-05 11:40 ` Stephen Rothwell
2008-10-06 6:14 ` Greg Ungerer
2009-01-05 12:17 ` Ingo Molnar
2009-01-05 17:38 ` KOSAKI Motohiro
2009-01-05 12:28 ` Nick Piggin
2009-01-12 22:06 ` Andrew Morton
2009-01-15 6:37 ` Nick Piggin
2009-01-06 9:46 ` Pavel Machek
2009-01-06 22:33 ` Folkert van Heusden
2009-01-06 22:38 ` Alan Cox
2009-01-06 22:57 ` Christoph Hellwig
2009-01-06 23:08 ` Andrew Morton
2009-01-07 1:05 ` Nick Piggin
2009-01-06 23:08 ` Andrew Morton [this message]
2009-01-06 23:22 ` Christoph Hellwig
2009-01-07 2:16 ` Dave Chinner
2009-01-08 15:50 ` Dmitri Monakhov
2009-01-06 23:11 ` Andrew Morton
2009-01-06 23:24 ` Christoph Hellwig
2009-01-07 1:14 ` Nick Piggin
2009-01-07 1:38 ` Andi Kleen
2009-01-07 1:49 ` Nick Piggin
2009-01-07 2:57 ` Andi Kleen
2009-01-07 3:28 ` Nick Piggin
2009-01-08 13:24 ` Pavel Machek
2009-01-10 15:07 ` Andi Kleen
2009-01-10 21:32 ` sync, reboot, and corrupting data [was Re: 2.6.29 -mm merge plans] Pavel Machek
2009-01-10 22:12 ` Andi Kleen
2009-01-10 22:26 ` Pavel Machek
2009-01-08 13:22 ` 2.6.29 -mm merge plans Pavel Machek
2009-01-06 23:13 ` Andrew Morton
2009-01-06 23:24 ` Christoph Hellwig
2009-01-06 23:38 ` Andrew Morton
2009-01-07 2:06 ` Nick Piggin
2009-01-07 2:16 ` Andrew Morton
2009-01-07 3:05 ` Nick Piggin
2009-01-07 4:16 ` Andrew Morton
2009-01-06 23:15 ` Andrew Morton
2009-01-06 23:25 ` Christoph Hellwig
2009-01-07 7:54 ` Christoph Hellwig
2009-01-07 7:59 ` Andrew Morton
2009-01-07 8:10 ` Christoph Hellwig
2009-01-06 23:17 ` Andrew Morton
2009-01-06 23:19 ` Christoph Hellwig
2009-01-06 23:26 ` Warren Turkal
2009-01-06 23:26 ` Warren Turkal
2009-01-12 3:19 ` Roman Zippel
2009-01-06 23:27 ` Diego E. 'Flameeyes' Pettenò
2009-01-06 23:31 ` Christoph Hellwig
2009-01-06 23:49 ` Harvey Harrison
2009-01-07 0:09 ` Diego E. 'Flameeyes' Pettenò
2009-01-07 0:16 ` Harvey Harrison
2009-01-12 4:21 ` Roman Zippel
2009-01-06 23:19 ` Andrew Morton
2009-01-08 19:11 ` Rodolfo Giometti
2009-01-12 20:23 ` Christoph Hellwig
2009-01-13 9:49 ` Rodolfo Giometti
2009-01-12 20:22 ` Christoph Hellwig
2009-01-13 9:47 ` Rodolfo Giometti
2009-01-06 23:21 ` Andrew Morton
2009-01-06 23:28 ` Andrew Morton
2009-01-07 2:21 ` Nick Piggin
2009-01-08 8:39 ` Miklos Szeredi
2009-01-15 6:45 ` Nick Piggin
2009-01-07 0:01 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106150855.5f362a2d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dmonakhov@openvz.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.