All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@console-pimps.org>
To: Wolfgang M??es <wolfgang.mues@auerswald.de>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes and enhancements for the MMC SPI driver
Date: Tue, 6 Jan 2009 16:10:06 +0000	[thread overview]
Message-ID: <20090106161006.GA28020@console-pimps.org> (raw)
In-Reply-To: <200901061517.01872.wolfgang.mues@auerswald.de>

On Tue, Jan 06, 2009 at 03:17:01PM +0100, Wolfgang M??es wrote:
> +
> +	/* The MMC framework does a good job of computing timeouts
> +           according to the mmc/sd standard. However, we found that in
> +           SPI mode, there are many cards which need a longer timeout
> +           of 1s after receiving a long stream of write data. */
> +	struct timeval tv = ktime_to_timeval(timeout);
> +	if (tv.tv_sec == 0)
> +		timeout = ktime_set(1,0);	
>  

Which cards are you having issues with?

Modifying the code to no longer abide by the standard doesn't seem like a
win to me.

  reply	other threads:[~2009-01-06 16:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-06 14:17 [PATCH] Fixes and enhancements for the MMC SPI driver Wolfgang Mües
2009-01-06 16:10 ` Matt Fleming [this message]
2009-01-08  8:22   ` Wolfgang Mües
2009-01-08  9:24     ` Matt Fleming
2009-01-08 10:19       ` Wolfgang Mües
2009-01-12 10:50       ` Wolfgang Mües
2009-01-24 12:23         ` Pierre Ossman
2009-01-12 23:45 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090106161006.GA28020@console-pimps.org \
    --to=matt@console-pimps.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wolfgang.mues@auerswald.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.