All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 5/9] ide: move ide_pktcmd_tf_load() to ide-atapi.c
Date: Tue, 06 Jan 2009 19:35:47 +0100	[thread overview]
Message-ID: <20090106183547.21193.43620.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20090106183520.21193.63704.sendpatchset@localhost.localdomain>

From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] ide: move ide_pktcmd_tf_load() to ide-atapi.c

Then make it static and remove 'dma' argument.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-atapi.c |   21 ++++++++++++++++++++-
 drivers/ide/ide-io.c    |   20 --------------------
 include/linux/ide.h     |    2 --
 3 files changed, 20 insertions(+), 23 deletions(-)

Index: b/drivers/ide/ide-atapi.c
===================================================================
--- a/drivers/ide/ide-atapi.c
+++ b/drivers/ide/ide-atapi.c
@@ -444,6 +444,25 @@ next_irq:
 	return ide_started;
 }
 
+static void ide_pktcmd_tf_load(ide_drive_t *drive, u32 tf_flags, u16 bcount)
+{
+	ide_hwif_t *hwif = drive->hwif;
+	ide_task_t task;
+	u8 dma = drive->dma;
+
+	memset(&task, 0, sizeof(task));
+	task.tf_flags = IDE_TFLAG_OUT_LBAH | IDE_TFLAG_OUT_LBAM |
+			IDE_TFLAG_OUT_FEATURE | tf_flags;
+	task.tf.feature = dma;		/* Use PIO/DMA */
+	task.tf.lbam    = bcount & 0xff;
+	task.tf.lbah    = (bcount >> 8) & 0xff;
+
+	ide_tf_dump(drive->name, &task.tf);
+	hwif->tp_ops->set_irq(hwif, 1);
+	SELECT_MASK(drive, 0);
+	hwif->tp_ops->tf_load(drive, &task);
+}
+
 static u8 ide_read_ireason(ide_drive_t *drive)
 {
 	ide_task_t task;
@@ -617,7 +636,7 @@ ide_startstop_t ide_issue_pc(ide_drive_t
 						       : WAIT_TAPE_CMD;
 	}
 
-	ide_pktcmd_tf_load(drive, tf_flags, bcount, drive->dma);
+	ide_pktcmd_tf_load(drive, tf_flags, bcount);
 
 	/* Issue the packet command */
 	if (drive->atapi_flags & IDE_AFLAG_DRQ_INTERRUPT) {
Index: b/drivers/ide/ide-io.c
===================================================================
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -1188,26 +1188,6 @@ void ide_do_drive_cmd(ide_drive_t *drive
 }
 EXPORT_SYMBOL(ide_do_drive_cmd);
 
-void ide_pktcmd_tf_load(ide_drive_t *drive, u32 tf_flags, u16 bcount, u8 dma)
-{
-	ide_hwif_t *hwif = drive->hwif;
-	ide_task_t task;
-
-	memset(&task, 0, sizeof(task));
-	task.tf_flags = IDE_TFLAG_OUT_LBAH | IDE_TFLAG_OUT_LBAM |
-			IDE_TFLAG_OUT_FEATURE | tf_flags;
-	task.tf.feature = dma;		/* Use PIO/DMA */
-	task.tf.lbam    = bcount & 0xff;
-	task.tf.lbah    = (bcount >> 8) & 0xff;
-
-	ide_tf_dump(drive->name, &task.tf);
-	hwif->tp_ops->set_irq(hwif, 1);
-	SELECT_MASK(drive, 0);
-	hwif->tp_ops->tf_load(drive, &task);
-}
-
-EXPORT_SYMBOL_GPL(ide_pktcmd_tf_load);
-
 void ide_pad_transfer(ide_drive_t *drive, int write, int len)
 {
 	ide_hwif_t *hwif = drive->hwif;
Index: b/include/linux/ide.h
===================================================================
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -1200,8 +1200,6 @@ void ide_read_bcount_and_ireason(ide_dri
 
 extern int drive_is_ready(ide_drive_t *);
 
-void ide_pktcmd_tf_load(ide_drive_t *, u32, u16, u8);
-
 int ide_check_atapi_device(ide_drive_t *, const char *);
 
 void ide_init_pc(struct ide_atapi_pc *);

  parent reply	other threads:[~2009-01-06 18:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-06 18:35 [PATCH 1/9] via82cxxx: fix cable warning message Bartlomiej Zolnierkiewicz
2009-01-06 18:35 ` [PATCH 2/9] sl82c105: remove dead code Bartlomiej Zolnierkiewicz
2009-01-11 21:14   ` Sergei Shtylyov
2009-01-12 17:59     ` Bartlomiej Zolnierkiewicz
2009-01-06 18:35 ` [PATCH 4/9] ide: fix IDE_DFLAG_NO_IO_32BIT handling Bartlomiej Zolnierkiewicz
2009-01-06 18:35 ` Bartlomiej Zolnierkiewicz [this message]
2009-01-11 21:18   ` [PATCH 5/9] ide: move ide_pktcmd_tf_load() to ide-atapi.c Sergei Shtylyov
2009-01-06 18:35 ` [PATCH 6/9] ide: no need to touch local IRQs in ide_probe_port() Bartlomiej Zolnierkiewicz
2009-01-06 18:36 ` [PATCH 7/9] ide: move ->rqsize init from init_irq() to ide_init_port() Bartlomiej Zolnierkiewicz
2009-01-11 20:58   ` Sergei Shtylyov
2009-01-14 17:25     ` Bartlomiej Zolnierkiewicz
2009-01-22 14:52       ` Bartlomiej Zolnierkiewicz
2009-01-06 18:36 ` [PATCH 8/9] ide: move ->lock and ->timer init from init_irq() to ide_init_port_data() Bartlomiej Zolnierkiewicz
2009-01-06 18:36 ` [PATCH 9/9] ide: init_irq() doesn't need to hold ide_cfg_mtx Bartlomiej Zolnierkiewicz
2009-01-11 21:17 ` [PATCH 1/9] via82cxxx: fix cable warning message Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090106183547.21193.43620.sendpatchset@localhost.localdomain \
    --to=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.