From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: netdev@vger.kernel.org
Subject: Re: few more fixes for iproute2/m_ipt
Date: Tue, 6 Jan 2009 19:43:12 -0800 [thread overview]
Message-ID: <20090106194312.1403ca53@extreme> (raw)
In-Reply-To: <200808060042.53503.denys@visp.net.lb>
On Wed, 6 Aug 2008 00:42:53 +0300
Denys Fedoryshchenko <denys@visp.net.lb> wrote:
> 1)optind according iptables sources have to be set to 0. If it is set to 1, in
> batch it will mess up things. Also in iptables sources i notice that ->tflags
> and ->used need to be reset.
>
> 2)Since target->t = fw_calloc(1, size); allocated memory in function build_st,
> it have to be freed at the end, or in batch we will have memory leak. TODO:
> Probably it must be freed in all "return -1" cases in parse_ipt after
> build_st. About this i am not sure, up to Stephen.
>
> 3)lname and new_name was malloc'ed, but not freed
Applied the last patch for this.
prev parent reply other threads:[~2009-01-07 3:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 21:42 few more fixes for iproute2/m_ipt Denys Fedoryshchenko
2008-08-06 10:04 ` jamal
2008-08-06 10:21 ` Denys Fedoryshchenko
2008-08-06 11:04 ` jamal
2008-08-06 11:26 ` Denys Fedoryshchenko
2008-08-06 12:46 ` jamal
2008-08-06 12:50 ` Denys Fedoryshchenko
2008-08-06 12:55 ` jamal
2008-08-06 12:56 ` Denys Fedoryshchenko
2008-08-06 12:59 ` Denys Fedoryshchenko
2008-08-06 13:17 ` jamal
2009-01-07 3:43 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106194312.1403ca53@extreme \
--to=shemminger@linux-foundation.org \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.