Re: [PATCH] rt2x00: Provide regulatory hint with rt2500pci/usb

[Ivo van Doorn <ivdoorn@gmail.com>]

On Tuesday 06 January 2009, Gertjan van Wingerde wrote:
> On 01/06/09 22:52, Ivo van Doorn wrote:
> >>>
> >>>        
> >>>> The problem isn't there for the bits that Ivo sent, as the rt2500 devices don't support the a band.
> >>>>
> >>>>          
> >>> For rt2500pci and rt2500usb there are chipsets which support 5GHz (they are rare, but they do exist),
> >>> comments for the Ralink drivers indicate they simply didn't add the regulatory domain definitions yet.
> >>>
> >>>        
> >> OK. But the EEPROM definitions I got from Ralink on the Country
> >> information indicate that there is only a single indication in the EEPROM.
> >>      
> >
> > That is right, like I said the comments already indicates there the legacy code didn't contain the
> > definitions (yet). ;)
> >
> >    
> >>> GertJan, some comments about your patch:
> >>>
> >>>
> >>>        
> >>>> diff --git a/drivers/net/wireless/rt2x00/rt2400pci.h b/drivers/net/wireless/rt2x00/rt2400pci.h
> >>>> index 9aefda4..986e428 100644
> >>>> --- a/drivers/net/wireless/rt2x00/rt2400pci.h
> >>>> +++ b/drivers/net/wireless/rt2x00/rt2400pci.h
> >>>> @@ -806,6 +806,13 @@
> >>>>    #define EEPROM_TXPOWER_2		FIELD16(0xff00)
> >>>>
> >>>>    /*
> >>>> + * EEPROM geography.
> >>>> + * GEO: Default geography setting for device.
> >>>> + */
> >>>> +#define EEPROM_GEOGRAPHY		0x17
> >>>> +#define EEPROM_GEOGRAPHY_GEO		FIELD16(0xff00)
> >>>>
> >>>>          
> >>> Where did you find this definition? I couldn't find it in the legacy driver or the specsheets.
> >>>
> >>>        
> >> I got an excerpt from the EEPROM definition for the rt2460 chip (which I
> >> received with the help of Luis). It's defined in there.
> >>      
> >
> > I assume you mean the file RT2460_DS_P1.3.pdf, could you point me to the right pagenumber?
> >
> >    
> No, I meant RT2460_EEPROM_Channels.pdf, which was sent by Ralink a 
> couple of months ago. You were copied on the email; let me know if you 
> can't find them. Note that these were only small excerpts from the 
> entire EEPROM definitions, only the parts on geography information.

ah those, I thought they only contained the valid values. :S
well ok, that means that this part of the patch is correct as well. :)

Ivo