From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754741AbZAGMmg (ORCPT ); Wed, 7 Jan 2009 07:42:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751002AbZAGMmZ (ORCPT ); Wed, 7 Jan 2009 07:42:25 -0500 Received: from 1wt.eu ([62.212.114.60]:1207 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbZAGMmY (ORCPT ); Wed, 7 Jan 2009 07:42:24 -0500 Date: Wed, 7 Jan 2009 13:39:02 +0100 From: Willy Tarreau To: Jarek Poplawski Cc: Jens Axboe , Changli Gao , Evgeniy Polyakov , Herbert Xu , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: Data corruption issue with splice() on 2.6.27.10 Message-ID: <20090107123902.GA6307@1wt.eu> References: <20081224152841.GB13113@1wt.eu> <20090106085442.GA9513@ff.dom.local> <20090106094138.GE25644@1wt.eu> <20090106100112.GB9513@ff.dom.local> <20090106155715.GA28783@1wt.eu> <20090107093915.GA6899@ff.dom.local> <20090107122205.GA6051@1wt.eu> <20090107123153.GA9597@ff.dom.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090107123153.GA9597@ff.dom.local> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 07, 2009 at 12:31:53PM +0000, Jarek Poplawski wrote: > On Wed, Jan 07, 2009 at 01:22:05PM +0100, Willy Tarreau wrote: > > [ CCing Evgeniy and Herbert who also participate to the thread ] > ... > > Well, I've just tested it. It did not fix the problem but made it worse. > ... > > Terrible mistake! Here is take 2. no problem. However, Herbert explained that this fix could not work for multiple reasons (refcounting not fixed where the issue really is). BTW, I've just tried it, and it crashed again, this time in tcp_send_ack(). Regards, Willy