From: Pierre Habouzit <madcoder@debian.org>
To: Kirill Smelkov <kirr@landau.phys.spbu.ru>
Cc: martin f krafft <madduck@madduck.net>,
git@vger.kernel.org, pasky@suse.cz
Subject: Re: [PATCH (topgit) 1/2] Implement setup_pager just like in git
Date: Wed, 07 Jan 2009 15:44:32 +0100 [thread overview]
Message-ID: <20090107144432.GC831@artemis.corp> (raw)
In-Reply-To: <20090107112754.GA15158@roro3>
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
On Wed, Jan 07, 2009 at 11:27:54AM +0000, Kirill Smelkov wrote:
> Martin, thanks for your review.
>
> I'll too reply inline:
>
> On Tue, Jan 06, 2009 at 09:32:03PM +0100, martin f krafft wrote:
> > Thanks, Kirill, for the patches. A couple of comments inline. I hope
> > Petr has a chance to look too.
> >
> > also sprach Kirill Smelkov <kirr@landau.phys.spbu.ru> [2009.01.06.1616 +0100]:
> > > +# isatty FD
> > > +isatty()
> > > +{
> > > + tty -s 0<&$1 || return 1
> > > + return 0
> > > +}
> >
> > You don't need any of the return statements. Functions' return
> > values are the return values of the last commands they execute.
>
> Agree, I'll rework isatty to be just
>
> isatty()
> {
> tty -s 0<&$1
> }
why not test -t 0 ? I'm not sure it's POSIX though.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-01-07 14:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 15:16 [PATCH (topgit) 0/2] tg-patch: fix pagination Kirill Smelkov
2009-01-06 15:16 ` [PATCH (topgit) 1/2] Implement setup_pager just like in git Kirill Smelkov
2009-01-06 20:32 ` martin f krafft
2009-01-07 10:35 ` Adeodato Simó
2009-01-07 11:27 ` Kirill Smelkov
2009-01-07 12:24 ` Thomas Rast
2009-01-07 22:00 ` Kirill Smelkov
2009-01-08 2:06 ` martin f krafft
2009-01-08 9:23 ` Kirill Smelkov
2009-01-07 14:24 ` Bert Wesarg
2009-01-07 14:44 ` Pierre Habouzit [this message]
2009-01-07 15:10 ` Petr Baudis
2009-01-06 15:16 ` [PATCH (topgit) 2/2] tg-patch: fix pagination Kirill Smelkov
2009-01-18 15:04 ` [PATCH (topgit) 0/2] " Kirill Smelkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107144432.GC831@artemis.corp \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=kirr@landau.phys.spbu.ru \
--cc=madduck@madduck.net \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.