From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc/cell: fix the prototype of create_vma_map
Date: Wed, 7 Jan 2009 20:01:51 +0100 [thread overview]
Message-ID: <200901072001.52336.arnd@arndb.de> (raw)
In-Reply-To: <20090107163657.4feddae0.sfr@canb.auug.org.au>
On Wednesday 07 January 2009, Stephen Rothwell wrote:
> Also the value originally comes from a notifier callback
> (spu_active_notify) which is passed this value as an "unsigned long".
The data that gets passed down here is originally the u64 object_id
from struct spu_context, but it gets passed as an unsigned long
through the notifier chain. I think either way is fine, as it's
not possible to use spu notifiers on a 32 bit kernel and I wouldn't
want to change it more fundamentally.
If you like, you can change the whole call chain from spu_active_notify
to pass a u64, but it woulnd't make the code more correct.
Original patch
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2009-01-07 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 23:58 [PATCH] powerpc/cell: fix the prototype of create_vma_map Stephen Rothwell
2009-01-07 3:34 ` Benjamin Herrenschmidt
2009-01-07 5:36 ` Stephen Rothwell
2009-01-07 19:01 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901072001.52336.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.