From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
trenn@suse.de
Subject: Re: [PATCH] ACPI: disable the ACPI backlight control on laptops with buggy _BCL methods
Date: Thu, 8 Jan 2009 03:32:50 +0000 [thread overview]
Message-ID: <20090108033250.GA2550@srcf.ucam.org> (raw)
In-Reply-To: <1231383496.20746.44.camel@rzhang-dt>
On Thu, Jan 08, 2009 at 10:58:16AM +0800, Zhang Rui wrote:
> Some users used to control the backlight via the platform interface.
> But commit c3d6de698c84efdbdd3781b7058bcc339ab43da8 disables the platform
> backlight control if ACPI video backlight control is available.
>
> This breaks the laptops with buggy _BCL/_BCM/_BQC methods. i.e. only ACPI
> backlight I/F are available on these laptops but they don't work.
>
> With this patch applied, the ACPI backlight control are disabled instead
> on these laptops.
Why? These all seem to behave consistently, so I can't see any problem
with us simply adding support for this varient. Disabling the ACPI
control when we have no idea whether there's a platform driver available
for the machine doesn't seem like the right fix.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-01-08 3:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 2:58 [PATCH] ACPI: disable the ACPI backlight control on laptops with buggy _BCL methods Zhang Rui
2009-01-08 3:11 ` Zhang Rui
2009-01-08 3:32 ` Matthew Garrett [this message]
2009-01-08 6:32 ` Zhang Rui
2009-01-08 12:43 ` Matthew Garrett
2009-01-09 1:13 ` Zhang Rui
2009-01-09 1:18 ` Matthew Garrett
2009-01-09 1:53 ` Zhang Rui
2009-01-09 1:55 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108033250.GA2550@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.