From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org,
"Nikula Jarkko (NRC/Helsinki)" <jarkko.nikula@nokia.com>
Subject: updated git pull request for omap compile fixes, mailbox and hsmmc
Date: Thu, 8 Jan 2009 09:36:12 +0200 [thread overview]
Message-ID: <20090108073611.GW27566@atomide.com> (raw)
In-Reply-To: <20090107220053.GD11471@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [090108 00:01]:
> On Wed, Jan 07, 2009 at 07:50:21PM +0200, Tony Lindgren wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [090107 18:18]:
> > > On Wed, Jan 07, 2009 at 01:17:45PM +0200, Tony Lindgren wrote:
> > > > - set_irq_type(OMAP_GPIO_IRQ(SW_ENTER_GPIO16), IRQ_TYPE_EDGE_RISING);
> > > > - if (request_irq(OMAP_GPIO_IRQ(SW_ENTER_GPIO16), &apollon_sw_interrupt,
> > > > + set_irq_type(gpio_to_irq(SW_ENTER_GPIO16), IRQ_TYPE_EDGE_RISING);
> > > > + if (request_irq(gpio_to_irq(SW_ENTER_GPIO16), &apollon_sw_interrupt,
> > >
> > > NAK. I wonder how the f*** this got anywhere near the mainline kernel.
> > > No no no no no. set_irq_type + request_irq is utter crap and should be
> > > rejected whenever its seen. There's absolutely no need for it -
> > > request_irq is sufficient. Get rid of this set_irq_type usage from
> > > everywhere please.
> >
> > Blind search and replace? :) I've removed the GPIO key code as there's
> > already a patch to do that cleaner with gpio_keys.
>
> Revised patch is fine.
OK, here's the pull request again:
The following changes since commit ede6f5aea054d3fb67c78857f7abdee602302043:
Linus Torvalds (1):
Fix up 64-bit byte swaps for most 32-bit architectures
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-misc-for-rmk
Hiroshi DOYU (10):
omap mailbox: cleanup omap2 register definition with macro
omap mailbox: add initial omap3 support
omap mailbox: print hardware revision at startup
omap mailbox: fix empty struct device for omap_mbox
omap mailbox: fix empty struct device for omap1
omap mailbox: fix empty struct device for omap2
omap mailbox: add save_/restore_ctx() for PM
omap mailbox: move mailbox.h into mailbox.c
omap mailbox: convert sequence bit checking to module paramter
omap mailbox: remove unnecessary header file inclusion
Jarkko Nikula (1):
ARM: OMAP: Fix gpio by switching to generic gpio calls, v2
Madhusudhan Chikkature (1):
omap mmc: Add new omap hsmmc controller for 2430 and 34xx, v3
Tony Lindgren (1):
ARM: OMAP: Fix missing includes
arch/arm/mach-omap1/board-sx1.c | 6 +-
arch/arm/mach-omap1/devices.c | 2 +-
arch/arm/mach-omap1/mailbox.c | 31 +-
arch/arm/mach-omap1/mcbsp.c | 1 +
arch/arm/mach-omap2/board-apollon.c | 64 +--
arch/arm/mach-omap2/board-ldp.c | 2 +-
arch/arm/mach-omap2/devices.c | 38 +-
arch/arm/mach-omap2/mailbox.c | 195 +++--
arch/arm/mach-omap2/mcbsp.c | 1 +
arch/arm/plat-omap/Kconfig | 8 +
arch/arm/plat-omap/i2c.c | 1 +
arch/arm/plat-omap/include/mach/gpio.h | 10 -
arch/arm/plat-omap/include/mach/mailbox.h | 27 +-
arch/arm/plat-omap/include/mach/omap34xx.h | 1 +
arch/arm/plat-omap/mailbox.c | 152 +++-
arch/arm/plat-omap/mailbox.h | 100 ---
drivers/mfd/twl4030-core.c | 1 +
drivers/mmc/host/Kconfig | 10 +
drivers/mmc/host/Makefile | 1 +
drivers/mmc/host/omap_hsmmc.c | 1242 ++++++++++++++++++++++++++++
drivers/mtd/onenand/omap2.c | 6 +-
21 files changed, 1581 insertions(+), 318 deletions(-)
delete mode 100644 arch/arm/plat-omap/mailbox.h
create mode 100644 drivers/mmc/host/omap_hsmmc.c
next prev parent reply other threads:[~2009-01-08 7:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 11:14 [PATCH 0/2] Fix omap builds Tony Lindgren
2009-01-07 11:16 ` [PATCH 1/2] ARM: OMAP: Fix missing includes Tony Lindgren
2009-01-07 11:17 ` [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls Tony Lindgren
2009-01-07 11:37 ` Jarkko Nikula
2009-01-07 12:03 ` Tony Lindgren
2009-01-07 13:26 ` Adrian Hunter
2009-01-07 13:18 ` Tony Lindgren
2009-01-07 16:18 ` Russell King - ARM Linux
2009-01-07 17:50 ` [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls, v2 Tony Lindgren
2009-01-07 22:00 ` Russell King - ARM Linux
2009-01-08 7:36 ` Tony Lindgren [this message]
2009-01-10 11:05 ` updated git pull request for omap compile fixes, mailbox and hsmmc Russell King - ARM Linux
2009-01-11 10:14 ` Russell King - ARM Linux
2009-01-12 6:24 ` Tony Lindgren
2009-01-12 16:43 ` Russell King - ARM Linux
2009-01-13 10:30 ` Tony Lindgren
2009-01-19 16:36 ` Russell King - ARM Linux
2009-01-23 0:45 ` Tony Lindgren
2009-01-12 6:28 ` Tony Lindgren
2009-01-10 11:02 ` [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls Russell King - ARM Linux
2009-01-12 13:14 ` Tony Lindgren
2009-01-10 10:57 ` [PATCH 1/2] ARM: OMAP: Fix missing includes Russell King - ARM Linux
2009-01-10 15:56 ` Samuel Ortiz
2009-01-10 16:20 ` Russell King - ARM Linux
2009-01-10 17:40 ` Samuel Ortiz
2009-01-10 17:56 ` Russell King - ARM Linux
2009-01-12 6:45 ` Tony Lindgren
2009-01-10 21:21 ` David Brownell
2009-01-10 20:49 ` David Brownell
2009-01-11 0:01 ` Samuel Ortiz
2009-01-12 6:31 ` Tony Lindgren
2009-01-07 11:25 ` git pull request for omap compile fixes, mailbox and hsmmc for current merge window Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108073611.GW27566@atomide.com \
--to=tony@atomide.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.