All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sheng Yang <sheng@linux.intel.com>
To: kvm@vger.kernel.org
Cc: Avi Kivity <avi@redhat.com>, Weidong Han <weidong.han@intel.com>,
	Amit Shah <amit.shah@qumranet.com>,
	"Ben-Ami Yassour" <benami@il.ibm.com>
Subject: Userspace specific host irq?
Date: Thu, 8 Jan 2009 14:56:30 +0800	[thread overview]
Message-ID: <200901081456.32082.sheng@linux.intel.com> (raw)

Hi all

This piece of code puzzled me at all time:

virt/kvm/kvm_main.c:assigned_device_update_intx()

> 		if (airq->host_irq)
> 			adev->host_irq = airq->host_irq;
> 		else
> 			adev->host_irq = adev->dev->irq;

I don't know why we can let userspace use a different host_irq rather than the 
real one.

I've queried Amit and Ben-Ami who are the original author about this question, 
and they also think this piece of code is redundancy. Send the question to the 
mailing list, if everyone agree, I would discard this one. 

Thanks!

-- 
regards
Yang, Sheng




                 reply	other threads:[~2009-01-08  6:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901081456.32082.sheng@linux.intel.com \
    --to=sheng@linux.intel.com \
    --cc=amit.shah@qumranet.com \
    --cc=avi@redhat.com \
    --cc=benami@il.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=weidong.han@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.