From: Tony Lindgren <tony@atomide.com>
To: Koen Kooi <k.kooi@student.utwente.nl>
Cc: Grazvydas Ignotas <notasas@gmail.com>,
"linux-omap@vger.kernel.org List" <linux-omap@vger.kernel.org>,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH 1/2] Add support for GPIO LEDs on pandora
Date: Thu, 8 Jan 2009 17:12:35 +0200 [thread overview]
Message-ID: <20090108151234.GR27566@atomide.com> (raw)
In-Reply-To: <03538FC0-A9B7-4770-B799-6730E9F09899@student.utwente.nl>
* Koen Kooi <k.kooi@student.utwente.nl> [090108 16:56]:
>
> Op 8 jan 2009, om 15:32 heeft Tony Lindgren het volgende geschreven:
>
>> * Grazvydas Ignotas <notasas@gmail.com> [081127 12:04]:
>>> Pandora has some LEDs and backlights connected to OMAP
>>> GPIOs and TWL4030/TPS65950 LED/PWM signals. This patch
>>> registers them all with leds-gpio driver. TWL4030/TPS65950
>>> controlled ones will be switched to PWM driver when it's ready.
>>
>> Pushing to l-o tree and adding to omap3-upstream queue for next
>> merge window. Not adding the defconfig changes to upstream queue
>> right now as the patch does not apply.
>>>
>>> + .name = "pandora::lcd_bl",
>>> + .default_trigger = "backlight",
>>> + .gpio = -EINVAL,
>>>
>
> That's a wrong usage of the 'backlight' trigger, which shouldn't get
> into mainline since it sets a bad example. The backlight trigger is
> meant to sync leds with the backlight (e.g. dim keypad leds), not to
> make leds a backlight.
OK, thanks, dropping from l-o and omap3-upstream.
Tony
next prev parent reply other threads:[~2009-01-08 15:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 10:02 [PATCH 1/2] Add support for GPIO LEDs on pandora Grazvydas Ignotas
2008-11-27 10:02 ` [PATCH 2/2] Enable LEDs in pandora defconfig Grazvydas Ignotas
2009-01-08 14:32 ` [PATCH 1/2] Add support for GPIO LEDs on pandora Tony Lindgren
2009-01-08 14:56 ` Koen Kooi
2009-01-08 15:12 ` Tony Lindgren [this message]
2009-01-08 15:28 ` Mark Brown
2009-01-08 16:29 ` Grazvydas Ignotas
2009-01-08 20:04 ` David Brownell
2009-01-09 11:53 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108151234.GR27566@atomide.com \
--to=tony@atomide.com \
--cc=k.kooi@student.utwente.nl \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.